Refs #638: Avoid shadowing arguments#639
Conversation
|
Thanks. Could you also please provide the actual warnings? I will take a look at the CI issue. |
The package no longer exists in the repo: https://packages.msys2.org/packages/mingw-w64-i686-clang. Let's wait a few more days to see if it re-appears, otherwise we disable it in the CI. |
I disabled it - please rebase. |
| std::string readUntil(Stream &stream, const Location &location, char start, char end, OutputList *outputList); | ||
| void lineDirective(unsigned int fileIndex, unsigned int line, Location &location); | ||
| void lineDirective(unsigned int fileId, unsigned int line, Location &location); | ||
|
|
There was a problem hiding this comment.
That change is a bit problematic because "fileIndex" has a special meaning within simplecpp and that would get lost...
There was a problem hiding this comment.
A rather awkward solution would be using fileIndex_. Maybe somebody else could chime in...
There was a problem hiding this comment.
And on side note - as index and ID are different things it should have been changed to fileIdx.
2 participants
Fixes
shadowFunctionthat appears with danmar/cppcheck#8303