add unit tests (for translations)#412
Open
ProfessorTom wants to merge 3 commits intodannagle:developmentfrom
Open
add unit tests (for translations)#412ProfessorTom wants to merge 3 commits intodannagle:developmentfrom
ProfessorTom wants to merge 3 commits intodannagle:developmentfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request:
This Pull Request adds some QtUnit unit tests to the project.
I thought it would be a good idea to add unit tests and wanted to test something that was fairly isolated. It turns out, I already provided the necessary isolation with code I added recently which is why I chose to unit test the translation.
As submitted, this PR only builds the unit test (singular because there's only one test even if it is parallelized) via CMake.
qmakecan be used and allegedly I have instructions on how to get the tests building withqmake. But this might be the necessary motivation to get off ofqmakeeverywhere we are still runningqmakebuilds and full get on CMake.NOTE: this PR does not provide ci configuration to run the tests as part of the build.
I tested this code on macOS Tahoe 26.3 on an M2 MacBook Pro; all bets are off other places, say SnapCraft.