Set stop=true if an error occurs while creating a socket connection#378
Open
ibraaaa wants to merge 1 commit intodanpaquin:masterfrom
Open
Set stop=true if an error occurs while creating a socket connection#378ibraaaa wants to merge 1 commit intodanpaquin:masterfrom
ibraaaa wants to merge 1 commit intodanpaquin:masterfrom
Conversation
When an exception is thrown during opening a connection or subscribing, self.stop still remains false. Users of WebsocketClient class will have no way to know whether a connection is live and functioning. This commit allows users to rely on self.stop to figure this out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception is thrown while opening a connection or subscribing,
stopstill remains false.Users of WebsocketClient class will have no way to know whether a connection is live and functioning. This commit allows users to rely on
ws_client.stopto figure this out.