use two providers on two network interfaces by yulujia · Pull Request #128 · daos-stack/cart

yulujia · 2019-04-25T23:15:56Z

run ofi+sockets on eth0, and ofi+psm2 on ib0

Signed-off-by: Yulu Jia yulu.jia@intel.com

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2019-04-25T23:17:04Z

+			continue;
+		D_DEBUG(DB_ALL, "na_type %d\n", na_type);
+		memset(na_conf->noc_ip_str, 0, INET_ADDRSTRLEN);
+		D_DEBUG(DB_ALL, "na_conf->noc_ip_str %s\n", na_conf->noc_ip_str);


(style) line over 80 characters

daosbuild1 · 2019-04-25T23:17:04Z

+//	crt_na_dict[na_type].nad_inited = 1;
+	D_DEBUG(DB_ALL, "YULU here\n");
+	D_DEBUG(DB_ALL, "na_conf->noc_ip_str %s na_conf->noc_port %d\n",
+			na_conf->noc_ip_str, na_conf->noc_port );


(style) space prohibited before that close parenthesis ')'

daosbuild1 · 2019-04-25T23:17:04Z

+		return -DER_INVAL;
+	}
+
+	// grab lock for crt_na_config_opt list


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:17:04Z

+	d_list_add_tail(&na_conf->noc_link, &crt_na_ofi_config_opt);
+	D_DEBUG(DB_ALL, "YULU here after add tail\n");
+out:
+	//unlock


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:17:04Z

+	D_DEBUG(DB_ALL, "YULU here after add tail\n");
+out:
+	//unlock
+	if (rc != -DER_SUCCESS) {


(style) suspect code indent for conditional statements (8, 0)

daosbuild1 · 2019-04-25T23:17:06Z

+	struct na_ofi_config	*na_conf = NULL;
+	struct na_ofi_config	*na_conf_tmp = NULL;
+
+//	D_ASSERTF(true == false, "implement this.\n");


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:17:06Z

+	struct na_ofi_config	*na_conf_tmp = NULL;
+
+//	D_ASSERTF(true == false, "implement this.\n");
+//	D_RWLOCK_WRLOCK();


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:17:06Z

+	struct test_ping_check_in	*e_req;
+	struct test_ping_check_out	*e_reply;
+	int				 rc = 0;
+	int				 ctx_id = -1;;


(style) Statements terminations use 1 semicolon

daosbuild1 · 2019-04-25T23:17:06Z

+	((d_string_t)		(name)			CRT_VAR) \
+	((bool)			(bool_val)		CRT_VAR)
+
+#define CRT_OSEQ_TEST_PING_CHECK /* output fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-25T23:17:06Z

+
+struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 };
+
+#define CRT_ISEQ_TEST_PING_CHECK /* input fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-25T23:17:12Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/1/display/redirect

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/run_test.sh:98:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:109:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:118:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

daosbuild1 · 2019-04-25T23:59:36Z

+			continue;
+		D_DEBUG(DB_ALL, "na_type %d\n", na_type);
+		memset(na_conf->noc_ip_str, 0, INET_ADDRSTRLEN);
+		D_DEBUG(DB_ALL, "na_conf->noc_ip_str %s\n", na_conf->noc_ip_str);


(style) line over 80 characters

daosbuild1 · 2019-04-25T23:59:36Z

+//	crt_na_dict[na_type].nad_inited = 1;
+	D_DEBUG(DB_ALL, "YULU here\n");
+	D_DEBUG(DB_ALL, "na_conf->noc_ip_str %s na_conf->noc_port %d\n",
+			na_conf->noc_ip_str, na_conf->noc_port );


(style) space prohibited before that close parenthesis ')'

daosbuild1 · 2019-04-25T23:59:37Z

+		return -DER_INVAL;
+	}
+
+	// grab lock for crt_na_config_opt list


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:59:37Z

+	d_list_add_tail(&na_conf->noc_link, &crt_na_ofi_config_opt);
+	D_DEBUG(DB_ALL, "YULU here after add tail\n");
+out:
+	//unlock


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:59:37Z

+	D_DEBUG(DB_ALL, "YULU here after add tail\n");
+out:
+	//unlock
+	if (rc != -DER_SUCCESS) {


(style) suspect code indent for conditional statements (8, 0)

daosbuild1 · 2019-04-25T23:59:38Z

+	struct na_ofi_config	*na_conf = NULL;
+	struct na_ofi_config	*na_conf_tmp = NULL;
+
+//	D_ASSERTF(true == false, "implement this.\n");


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:59:38Z

+	struct na_ofi_config	*na_conf_tmp = NULL;
+
+//	D_ASSERTF(true == false, "implement this.\n");
+//	D_RWLOCK_WRLOCK();


(style) do not use C99 // comments

daosbuild1 · 2019-04-25T23:59:39Z

+	struct test_ping_check_in	*e_req;
+	struct test_ping_check_out	*e_reply;
+	int				 rc = 0;
+	int				 ctx_id = -1;;


(style) Statements terminations use 1 semicolon

daosbuild1 · 2019-04-25T23:59:39Z

+	((d_string_t)		(name)			CRT_VAR) \
+	((bool)			(bool_val)		CRT_VAR)
+
+#define CRT_OSEQ_TEST_PING_CHECK /* output fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-25T23:59:39Z

+
+struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 };
+
+#define CRT_ISEQ_TEST_PING_CHECK /* input fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-25T23:59:45Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/2/display/redirect

daosbuild1 · 2019-04-26T00:00:13Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/2/display/redirect

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/run_test.sh:98:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:109:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:118:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

daosbuild1 · 2019-04-26T23:37:56Z

+		D_GOTO(out, rc = -DER_PROTO);
+	}
+
+//	rc = crt_get_port(&port);


(style) do not use C99 // comments

daosbuild1 · 2019-04-26T23:37:56Z

+	}
+
+	/* disable this ENV for now */
+//	port_str = getenv("OFI_PORT_2");


(style) do not use C99 // comments

daosbuild1 · 2019-04-26T23:37:56Z

+        procrtn = self.launch_test(testmsg, '1', self.pass_env, \
+                                   cli_arg='tests/test_multi_prov' + \
+                                             ' --name client_group' + \
+                                             ' --attach_to service_group --ctx_num 2',


(pylint-line-too-long) Line too long (86/80)

daosbuild1 · 2019-04-26T23:37:56Z

+	int		na_id;
 } crt_init_options_t;

+typedef struct crt_ctx_init_opt {


(style) do not add new typedefs

daosbuild1 · 2019-04-26T23:37:56Z

+	((d_string_t)		(name)			CRT_VAR) \
+	((bool)			(bool_val)		CRT_VAR)
+
+#define CRT_OSEQ_TEST_PING_CHECK /* output fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-26T23:37:56Z

+
+struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 };
+
+#define CRT_ISEQ_TEST_PING_CHECK /* input fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-26T23:38:01Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:38:20Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:38:24Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:39:00Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:39:01Z

Test stage Build on LEAP 42.3 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:39:02Z

Test stage Build on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:39:14Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-26T23:42:22Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/3/display/redirect

daosbuild1 · 2019-04-29T22:01:13Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

daosbuild1 · 2019-04-29T22:01:15Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

daosbuild1 · 2019-04-29T22:01:48Z

Test stage Build on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

daosbuild1 · 2019-04-29T22:01:50Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

daosbuild1 · 2019-04-29T22:01:59Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

daosbuild1 · 2019-04-29T22:02:03Z

Test stage Build on LEAP 42.3 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

daosbuild1 · 2019-04-29T22:06:51Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/4/display/redirect

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/run_test.sh:98:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:109:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:118:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

daosbuild1 · 2019-04-29T22:37:09Z

+		D_GOTO(out, rc = -DER_PROTO);
+	}
+
+//	rc = crt_get_port(&port);


(style) do not use C99 // comments

daosbuild1 · 2019-04-29T22:37:10Z

+	}
+
+	/* disable this ENV for now */
+//	port_str = getenv("OFI_PORT_2");


(style) do not use C99 // comments

daosbuild1 · 2019-04-29T22:37:10Z

+        procrtn = self.launch_test(testmsg, '1', self.pass_env, \
+                                   cli_arg='tests/test_multi_prov' + \
+                                             ' --name client_group' + \
+                                             ' --attach_to service_group --ctx_num 2',


(pylint-line-too-long) Line too long (86/80)

daosbuild1 · 2019-04-29T22:37:10Z

+	int		na_id;
 } crt_init_options_t;

+typedef struct crt_ctx_init_opt {


(style) do not add new typedefs

daosbuild1 · 2019-04-29T22:37:10Z

+	((d_string_t)		(name)			CRT_VAR) \
+	((bool)			(bool_val)		CRT_VAR)
+
+#define CRT_OSEQ_TEST_PING_CHECK /* output fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-29T22:37:10Z

+
+struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 };
+
+#define CRT_ISEQ_TEST_PING_CHECK /* input fields */		 \


(style) Macros with complex values should be enclosed in parentheses

daosbuild1 · 2019-04-29T22:37:15Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/5/display/redirect

daosbuild1 · 2019-04-29T23:10:32Z

Test stage Single-node-valgrind completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/5/display/redirect

daosbuild1 · 2019-04-29T23:10:36Z

Test stage Single-node completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/5/display/redirect

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/16/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_group.c:1040:
(style) line over 80 characters

src/cart/crt_group.c:487:
(style) line over 80 characters

src/cart/crt_group.c:499:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:631:
(style) line over 80 characters

src/cart/crt_swim.c:409:
(style) Missing a blank line after declarations

src/cart/crt_swim.c:135:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:447:
(style) line over 80 characters

utils/run_test.sh:112:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:121:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:101:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

src/test/test_group_rpc.h:49:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_group_rpc.h:43:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_multi_prov_cli.c:344:
(style) line over 80 characters

src/test/test_multi_prov_cli.c:226:
(style) do not use C99 // comments

src/test/test_multi_prov_cli.c:259:
(style) code indent should use tabs where possible

src/test/test_multi_prov_cli.c:293:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_cli.c:422:
(style) Block comments use * on subsequent lines

src/include/cart/api.h:1783:
(style) line over 80 characters

src/cart/crt_context.c:253:
(style) line over 80 characters

src/cart/crt_hg.c:860:
(style) line over 80 characters

src/cart/crt_hg.c:863:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:384:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:150:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:541:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:546:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:420:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:552:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:182:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:442:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:75:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:466:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:469:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:344:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:570:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:351:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:352:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:357:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:488:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:364:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:365:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:495:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:374:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:375:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:383:
(style) do not use C99 // comments

FYI: Errors found in lines not modified in the patch:

src/cart/crt_init.c:408:
(style) suspect code indent for conditional statements (16, 0)

daosbuild1 · 2019-08-20T19:26:56Z

+	for (na_idx = 0; crt_na_dict[na_idx].nad_str != NULL;
+			na_idx++) {
+		if (!strncmp(addr_env, crt_na_dict[na_idx].nad_str,
+					strlen(crt_na_dict[na_idx].nad_str) + 1)) {


(style) line over 80 characters

daosbuild1 · 2019-08-20T19:26:56Z

-		if ((crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS_RXM ||
-		     crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS) &&
-		    crt_gdata.cg_share_na) {
+		if (( na_type == CRT_NA_OFI_VERBS_RXM ||


(style) space prohibited after that open parenthesis '('

daosbuild1 · 2019-08-20T19:26:57Z


-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())


(style) do not use C99 // comments

daosbuild1 · 2019-08-20T19:26:57Z

-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())
+//			crt_swim_fini();


(style) do not use C99 // comments

daosbuild1 · 2019-08-20T19:26:57Z

 	D_DEBUG(DB_ALL, "set cg_share_na %d, cg_ctx_max_num %d.\n",
-		crt_gdata.cg_share_na, crt_gdata.cg_ctx_max_num);
-	if (crt_gdata.cg_share_na == false && crt_gdata.cg_ctx_max_num > 1)
+		crt_gdata.cg_share_na[na_type], crt_gdata.cg_ctx_max_num[na_type]);


(style) line over 80 characters

daosbuild1 · 2019-08-20T19:27:00Z

+			}

-		d_hash_rec_decref(&grp_priv->gp_uri_lookup_cache, rlink);
+			d_hash_rec_decref(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-08-20T19:27:01Z

-		for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
-			crt_grp_lc_uri_remove(grp_priv, i, rank);
+			for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
+				crt_grp_lc_uri_remove(grp_priv, na_type, i, rank);


(style) line over 80 characters

daosbuild1 · 2019-08-20T19:27:01Z


-		d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache,
-			&rank, sizeof(d_rank_t));
+			d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-08-20T19:27:01Z

+
+free_htables:
+	for (j = 0; j < i; j++) {
+		rc2 = d_hash_table_destroy_inplace(&htables[j], true /* force */);


(style) line over 80 characters

daosbuild1 · 2019-08-20T19:27:01Z


 static inline int
-grp_li_uri_set(struct crt_lookup_item *li, int tag, const char *uri)
+grp_li_uri_set(struct crt_lookup_item *li, int na_type, int tag, const char *uri)


(style) line over 80 characters

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/16/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 0 errors. Remaining unannotated errors:

src/cart/crt_init.c:97:
(style) line over 80 characters

src/cart/crt_init.c:354:
(style) space prohibited after that open parenthesis '('

src/cart/crt_init.c:552:
(style) do not use C99 // comments

src/cart/crt_init.c:553:
(style) do not use C99 // comments

src/cart/crt_init.c:180:
(style) line over 80 characters

src/cart/crt_init.c:181:
(style) line over 80 characters

src/cart/crt_init.c:408:
(style) suspect code indent for conditional statements (16, 0)

src/cart/crt_init.c:409:
(style) do not use C99 // comments

src/cart/crt_init.c:410:
(style) do not use C99 // comments

src/cart/crt_init.c:411:
(style) do not use C99 // comments

src/cart/crt_init.c:412:
(style) do not use C99 // comments

src/cart/crt_init.c:413:
(style) do not use C99 // comments

src/cart/crt_init.c:414:
(style) do not use C99 // comments

src/test/SConscript:51:
(pylint-line-too-long) Line too long (83/80)

src/cart/crt_group.c:1029:
(style) line over 80 characters

src/cart/crt_group.c:392:
(style) line over 80 characters

src/cart/crt_group.c:2832:
(style) line over 80 characters

src/cart/crt_group.c:2833:
(style) line over 80 characters

src/cart/crt_group.c:3474:
(style) line over 80 characters

src/cart/crt_group.c:407:
(style) line over 80 characters

src/cart/crt_group.c:797:
(style) line over 80 characters

src/cart/crt_group.c:1055:
(style) line over 80 characters

src/cart/crt_group.c:546:
(style) line over 80 characters

src/cart/crt_group.c:755:
(style) line over 80 characters

src/cart/crt_group.c:4663:
(style) line over 80 characters

src/cart/crt_group.c:4666:
(style) line over 80 characters

src/cart/crt_group.c:671:
(style) line over 80 characters

src/cart/crt_group.c:4670:
(style) line over 80 characters

src/cart/crt_group.c:4674:
(style) line over 80 characters

src/cart/crt_group.c:4676:
(style) line over 80 characters

src/cart/crt_group.c:467:
(style) line over 80 characters

src/cart/crt_group.c:346:
(style) line over 80 characters

src/cart/crt_group.c:1040:
(style) line over 80 characters

src/cart/crt_group.c:487:
(style) line over 80 characters

src/cart/crt_group.c:499:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:631:
(style) line over 80 characters

src/cart/crt_swim.c:409:
(style) Missing a blank line after declarations

src/cart/crt_swim.c:135:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:447:
(style) line over 80 characters

utils/run_test.sh:112:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:121:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:101:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

src/test/test_group_rpc.h:49:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_group_rpc.h:43:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_multi_prov_cli.c:344:
(style) line over 80 characters

src/test/test_multi_prov_cli.c:226:
(style) do not use C99 // comments

src/test/test_multi_prov_cli.c:259:
(style) code indent should use tabs where possible

src/test/test_multi_prov_cli.c:293:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_cli.c:422:
(style) Block comments use * on subsequent lines

src/include/cart/api.h:1783:
(style) line over 80 characters

src/cart/crt_context.c:253:
(style) line over 80 characters

src/cart/crt_hg.c:860:
(style) line over 80 characters

src/cart/crt_hg.c:863:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:384:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:150:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:541:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:546:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:420:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:552:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:182:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:442:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:75:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:466:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:469:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:344:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:570:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:351:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:352:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:357:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:488:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:364:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:365:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:495:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:374:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:375:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:383:
(style) do not use C99 // comments

Note: Unable to provide any annotated comments due to GitHub API limitations.

daosbuild1 · 2019-08-20T19:27:17Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/16/execution/node/44/log

daosbuild1 · 2019-08-20T19:29:25Z

Test stage Build DEB on Ubuntu 18.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/16/execution/node/279/log

daosbuild1 · 2019-08-20T19:55:15Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/16/execution/node/298/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/17/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_group.c:1040:
(style) line over 80 characters

src/cart/crt_group.c:487:
(style) line over 80 characters

src/cart/crt_group.c:499:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:631:
(style) line over 80 characters

src/cart/crt_swim.c:409:
(style) Missing a blank line after declarations

src/cart/crt_swim.c:135:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:447:
(style) line over 80 characters

utils/run_test.sh:112:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:121:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:101:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

src/test/test_group_rpc.h:49:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_group_rpc.h:43:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_multi_prov_cli.c:344:
(style) line over 80 characters

src/test/test_multi_prov_cli.c:226:
(style) do not use C99 // comments

src/test/test_multi_prov_cli.c:259:
(style) code indent should use tabs where possible

src/test/test_multi_prov_cli.c:293:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_cli.c:422:
(style) Block comments use * on subsequent lines

src/include/cart/api.h:1783:
(style) line over 80 characters

src/cart/crt_context.c:253:
(style) line over 80 characters

src/cart/crt_hg.c:860:
(style) line over 80 characters

src/cart/crt_hg.c:863:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:384:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:150:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:541:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:546:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:420:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:552:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:182:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:442:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:75:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:466:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:469:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:344:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:570:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:351:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:352:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:357:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:488:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:364:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:365:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:495:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:374:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:375:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:383:
(style) do not use C99 // comments

FYI: Errors found in lines not modified in the patch:

src/cart/crt_init.c:408:
(style) suspect code indent for conditional statements (16, 0)

daosbuild1 · 2019-08-20T22:47:37Z

+	for (na_idx = 0; crt_na_dict[na_idx].nad_str != NULL;
+			na_idx++) {
+		if (!strncmp(addr_env, crt_na_dict[na_idx].nad_str,
+					strlen(crt_na_dict[na_idx].nad_str) + 1)) {


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:37Z

-		if ((crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS_RXM ||
-		     crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS) &&
-		    crt_gdata.cg_share_na) {
+		if (( na_type == CRT_NA_OFI_VERBS_RXM ||


(style) space prohibited after that open parenthesis '('

daosbuild1 · 2019-08-20T22:47:37Z


-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())


(style) do not use C99 // comments

daosbuild1 · 2019-08-20T22:47:37Z

-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())
+//			crt_swim_fini();


(style) do not use C99 // comments

daosbuild1 · 2019-08-20T22:47:37Z

 	D_DEBUG(DB_ALL, "set cg_share_na %d, cg_ctx_max_num %d.\n",
-		crt_gdata.cg_share_na, crt_gdata.cg_ctx_max_num);
-	if (crt_gdata.cg_share_na == false && crt_gdata.cg_ctx_max_num > 1)
+		crt_gdata.cg_share_na[na_type], crt_gdata.cg_ctx_max_num[na_type]);


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:41Z

+			}

-		d_hash_rec_decref(&grp_priv->gp_uri_lookup_cache, rlink);
+			d_hash_rec_decref(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:41Z

-		for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
-			crt_grp_lc_uri_remove(grp_priv, i, rank);
+			for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
+				crt_grp_lc_uri_remove(grp_priv, na_type, i, rank);


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:41Z


-		d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache,
-			&rank, sizeof(d_rank_t));
+			d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:41Z

+
+free_htables:
+	for (j = 0; j < i; j++) {
+		rc2 = d_hash_table_destroy_inplace(&htables[j], true /* force */);


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:41Z


 static inline int
-grp_li_uri_set(struct crt_lookup_item *li, int tag, const char *uri)
+grp_li_uri_set(struct crt_lookup_item *li, int na_type, int tag, const char *uri)


(style) line over 80 characters

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/17/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_group.c:1040:
(style) line over 80 characters

src/cart/crt_group.c:487:
(style) line over 80 characters

src/cart/crt_group.c:499:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:631:
(style) line over 80 characters

src/cart/crt_swim.c:409:
(style) Missing a blank line after declarations

src/cart/crt_swim.c:135:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:447:
(style) line over 80 characters

utils/run_test.sh:112:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:121:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:101:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

src/test/test_group_rpc.h:49:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_group_rpc.h:43:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_multi_prov_cli.c:344:
(style) line over 80 characters

src/test/test_multi_prov_cli.c:226:
(style) do not use C99 // comments

src/test/test_multi_prov_cli.c:259:
(style) code indent should use tabs where possible

src/test/test_multi_prov_cli.c:293:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_cli.c:422:
(style) Block comments use * on subsequent lines

src/include/cart/api.h:1783:
(style) line over 80 characters

src/cart/crt_context.c:253:
(style) line over 80 characters

src/cart/crt_hg.c:860:
(style) line over 80 characters

src/cart/crt_hg.c:863:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:384:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:150:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:541:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:546:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:420:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:552:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:182:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:442:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:75:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:466:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:469:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:344:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:570:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:351:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:352:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:357:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:488:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:364:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:365:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:495:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:374:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:375:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:383:
(style) do not use C99 // comments

FYI: Errors found in lines not modified in the patch:

src/cart/crt_init.c:408:
(style) suspect code indent for conditional statements (16, 0)

daosbuild1 · 2019-08-20T22:47:53Z

+	for (na_idx = 0; crt_na_dict[na_idx].nad_str != NULL;
+			na_idx++) {
+		if (!strncmp(addr_env, crt_na_dict[na_idx].nad_str,
+					strlen(crt_na_dict[na_idx].nad_str) + 1)) {


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:53Z

-		if ((crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS_RXM ||
-		     crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS) &&
-		    crt_gdata.cg_share_na) {
+		if (( na_type == CRT_NA_OFI_VERBS_RXM ||


(style) space prohibited after that open parenthesis '('

daosbuild1 · 2019-08-20T22:47:53Z


-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())


(style) do not use C99 // comments

daosbuild1 · 2019-08-20T22:47:53Z

-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())
+//			crt_swim_fini();


(style) do not use C99 // comments

daosbuild1 · 2019-08-20T22:47:54Z

 	D_DEBUG(DB_ALL, "set cg_share_na %d, cg_ctx_max_num %d.\n",
-		crt_gdata.cg_share_na, crt_gdata.cg_ctx_max_num);
-	if (crt_gdata.cg_share_na == false && crt_gdata.cg_ctx_max_num > 1)
+		crt_gdata.cg_share_na[na_type], crt_gdata.cg_ctx_max_num[na_type]);


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:58Z

+			}

-		d_hash_rec_decref(&grp_priv->gp_uri_lookup_cache, rlink);
+			d_hash_rec_decref(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:58Z

-		for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
-			crt_grp_lc_uri_remove(grp_priv, i, rank);
+			for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
+				crt_grp_lc_uri_remove(grp_priv, na_type, i, rank);


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:59Z


-		d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache,
-			&rank, sizeof(d_rank_t));
+			d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:59Z

+
+free_htables:
+	for (j = 0; j < i; j++) {
+		rc2 = d_hash_table_destroy_inplace(&htables[j], true /* force */);


(style) line over 80 characters

daosbuild1 · 2019-08-20T22:47:59Z


 static inline int
-grp_li_uri_set(struct crt_lookup_item *li, int tag, const char *uri)
+grp_li_uri_set(struct crt_lookup_item *li, int na_type, int tag, const char *uri)


(style) line over 80 characters

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/17/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 0 errors. Remaining unannotated errors:

src/cart/crt_init.c:97:
(style) line over 80 characters

src/cart/crt_init.c:354:
(style) space prohibited after that open parenthesis '('

src/cart/crt_init.c:552:
(style) do not use C99 // comments

src/cart/crt_init.c:553:
(style) do not use C99 // comments

src/cart/crt_init.c:180:
(style) line over 80 characters

src/cart/crt_init.c:181:
(style) line over 80 characters

src/cart/crt_init.c:408:
(style) suspect code indent for conditional statements (16, 0)

src/cart/crt_init.c:409:
(style) do not use C99 // comments

src/cart/crt_init.c:410:
(style) do not use C99 // comments

src/cart/crt_init.c:411:
(style) do not use C99 // comments

src/cart/crt_init.c:412:
(style) do not use C99 // comments

src/cart/crt_init.c:413:
(style) do not use C99 // comments

src/cart/crt_init.c:414:
(style) do not use C99 // comments

src/test/SConscript:51:
(pylint-line-too-long) Line too long (83/80)

src/cart/crt_group.c:1029:
(style) line over 80 characters

src/cart/crt_group.c:392:
(style) line over 80 characters

src/cart/crt_group.c:2832:
(style) line over 80 characters

src/cart/crt_group.c:2833:
(style) line over 80 characters

src/cart/crt_group.c:3474:
(style) line over 80 characters

src/cart/crt_group.c:407:
(style) line over 80 characters

src/cart/crt_group.c:797:
(style) line over 80 characters

src/cart/crt_group.c:1055:
(style) line over 80 characters

src/cart/crt_group.c:546:
(style) line over 80 characters

src/cart/crt_group.c:755:
(style) line over 80 characters

src/cart/crt_group.c:4663:
(style) line over 80 characters

src/cart/crt_group.c:4666:
(style) line over 80 characters

src/cart/crt_group.c:671:
(style) line over 80 characters

src/cart/crt_group.c:4670:
(style) line over 80 characters

src/cart/crt_group.c:4674:
(style) line over 80 characters

src/cart/crt_group.c:4676:
(style) line over 80 characters

src/cart/crt_group.c:467:
(style) line over 80 characters

src/cart/crt_group.c:346:
(style) line over 80 characters

src/cart/crt_group.c:1040:
(style) line over 80 characters

src/cart/crt_group.c:487:
(style) line over 80 characters

src/cart/crt_group.c:499:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:631:
(style) line over 80 characters

src/cart/crt_swim.c:409:
(style) Missing a blank line after declarations

src/cart/crt_swim.c:135:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:447:
(style) line over 80 characters

utils/run_test.sh:112:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:121:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:101:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

src/test/test_group_rpc.h:49:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_group_rpc.h:43:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_multi_prov_cli.c:344:
(style) line over 80 characters

src/test/test_multi_prov_cli.c:226:
(style) do not use C99 // comments

src/test/test_multi_prov_cli.c:259:
(style) code indent should use tabs where possible

src/test/test_multi_prov_cli.c:293:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_cli.c:422:
(style) Block comments use * on subsequent lines

src/include/cart/api.h:1783:
(style) line over 80 characters

src/cart/crt_context.c:253:
(style) line over 80 characters

src/cart/crt_hg.c:860:
(style) line over 80 characters

src/cart/crt_hg.c:863:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:384:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:150:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:541:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:546:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:420:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:552:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:182:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:442:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:75:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:466:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:469:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:344:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:570:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:351:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:352:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:357:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:488:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:364:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:365:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:495:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:374:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:375:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:383:
(style) do not use C99 // comments

Note: Unable to provide any annotated comments due to GitHub API limitations.

daosbuild1 · 2019-08-20T22:48:12Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/17/execution/node/44/log

daosbuild1 · 2019-08-20T23:15:14Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/17/execution/node/294/log

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/18/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_group.c:487:
(style) line over 80 characters

src/cart/crt_group.c:752:
(style) line over 80 characters

src/cart/crt_group.c:499:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:628:
(style) line over 80 characters

src/cart/crt_swim.c:409:
(style) Missing a blank line after declarations

src/cart/crt_swim.c:135:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:447:
(style) line over 80 characters

utils/run_test.sh:112:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:121:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:101:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

src/test/test_group_rpc.h:49:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_group_rpc.h:43:
(style) Macros with complex values should be enclosed in parentheses

src/test/test_multi_prov_cli.c:344:
(style) line over 80 characters

src/test/test_multi_prov_cli.c:226:
(style) do not use C99 // comments

src/test/test_multi_prov_cli.c:259:
(style) code indent should use tabs where possible

src/test/test_multi_prov_cli.c:293:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_cli.c:422:
(style) Block comments use * on subsequent lines

src/include/cart/api.h:1783:
(style) line over 80 characters

src/cart/crt_context.c:253:
(style) line over 80 characters

src/cart/crt_hg.c:860:
(style) line over 80 characters

src/cart/crt_hg.c:863:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:384:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:150:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:541:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:546:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:420:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:552:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:182:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:442:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:75:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:466:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:469:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:344:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:570:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:351:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:352:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:357:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:488:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:364:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:365:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:495:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:374:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:375:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:383:
(style) do not use C99 // comments

FYI: Errors found in lines not modified in the patch:

src/cart/crt_init.c:408:
(style) suspect code indent for conditional statements (16, 0)

daosbuild1 · 2019-09-06T18:44:47Z

+	for (na_idx = 0; crt_na_dict[na_idx].nad_str != NULL;
+			na_idx++) {
+		if (!strncmp(addr_env, crt_na_dict[na_idx].nad_str,
+					strlen(crt_na_dict[na_idx].nad_str) + 1)) {


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:47Z

-		if ((crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS_RXM ||
-		     crt_gdata.cg_na_plugin == CRT_NA_OFI_VERBS) &&
-		    crt_gdata.cg_share_na) {
+		if (( na_type == CRT_NA_OFI_VERBS_RXM ||


(style) space prohibited after that open parenthesis '('

daosbuild1 · 2019-09-06T18:44:47Z


-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())


(style) do not use C99 // comments

daosbuild1 · 2019-09-06T18:44:47Z

-		if (crt_is_service())
-			crt_swim_fini();
+//		if (crt_is_service())
+//			crt_swim_fini();


(style) do not use C99 // comments

daosbuild1 · 2019-09-06T18:44:48Z

 	D_DEBUG(DB_ALL, "set cg_share_na %d, cg_ctx_max_num %d.\n",
-		crt_gdata.cg_share_na, crt_gdata.cg_ctx_max_num);
-	if (crt_gdata.cg_share_na == false && crt_gdata.cg_ctx_max_num > 1)
+		crt_gdata.cg_share_na[na_type], crt_gdata.cg_ctx_max_num[na_type]);


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:51Z

-		for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
-			crt_grp_lc_uri_remove(grp_priv, i, rank);
+			for (i = 0; i < CRT_SRV_CONTEXT_NUM; i++)
+				crt_grp_lc_uri_remove(grp_priv, na_type, i, rank);


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:51Z


-		d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache,
-			&rank, sizeof(d_rank_t));
+			d_hash_rec_delete(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:51Z

-			d_hash_rec_decref(
-				&default_grp_priv->gp_lookup_cache[ctx_idx],
-				rlink);
+			d_hash_rec_decref(&default_grp_priv->gp_lookup_cache[na_type][ctx_idx],


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:51Z

+
+free_htables:
+	for (j = 0; j < i; j++) {
+		rc2 = d_hash_table_destroy_inplace(&htables[j], true /* force */);


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:51Z


 static inline int
-grp_li_uri_set(struct crt_lookup_item *li, int tag, const char *uri)
+grp_li_uri_set(struct crt_lookup_item *li, int na_type, int tag, const char *uri)


(style) line over 80 characters

daosbuild1 · 2019-09-06T18:44:59Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/18/execution/node/44/log

daosbuild1 · 2019-09-06T19:11:47Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/18/execution/node/274/log

Add multi provider support in cart. User can specify provider type when creating a cart context. new functions: int crt_context_create_opt(crt_context_t *crt_ctx, crt_ctx_init_opt_t *opt); int crt_context_na_type(crt_context_t crt_ctx); int crt_self_uri_get_na(int na_type, int tag, char **uri); seperate the following two functions from crt_init() and crt_finalize() int crt_swim_init(int crt_ctx_idx); void crt_swim_fini(void); Signed-off-by: Yulu Jia <yulu.jia@intel.com>

Updated patch

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-128/19/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

Note: Error annotation limited to the first 31 errors. Remaining unannotated errors:

src/cart/crt_group.c:3387:
(style) line over 80 characters

src/cart/crt_group.c:3389:
(style) line over 80 characters

src/cart/crt_group.c:840:
(style) line over 80 characters

src/cart/crt_group.c:3383:
(style) line over 80 characters

src/cart/crt_group.c:462:
(style) line over 80 characters

src/cart/crt_group.c:339:
(style) line over 80 characters

src/cart/crt_group.c:2014:
(style) line over 80 characters

src/cart/crt_group.c:2015:
(style) line over 80 characters

src/cart/crt_group.c:482:
(style) line over 80 characters

src/cart/crt_group.c:742:
(style) line over 80 characters

src/cart/crt_group.c:620:
(style) line over 80 characters

src/cart/crt_group.c:494:
(style) Block comments use a trailing */ on a separate line

src/cart/crt_group.c:1011:
(style) line over 80 characters

src/cart/crt_group.c:1917:
(style) do not use C99 // comments

src/cart/crt_swim.c:501:
(style) Missing a blank line after declarations

src/cart/crt_context.c:253:
(style) line over 80 characters

test/cart_test_multi_prov.py:65:
(pylint-import-error) Unable to import 'commontestsuite'

test/cart_test_multi_prov.py:111:
(pylint-line-too-long) Line too long (86/80)

src/include/cart/types.h:98:
(style) do not add new typedefs

src/include/cart/types.h:123:
(style) do not add new typedefs

src/include/cart/types.h:106:
(style) trailing whitespace

src/cart/crt_group.h:278:
(style) line over 80 characters

utils/run_test.sh:114:
(lint) Double quote to prevent globbing and word splitting. [SC2086]

utils/run_test.sh:43:
(lint) JENKINS_TEST_LIST appears unused. Verify it or export it. [SC2034]

src/test/test_group.c:52:
(style) do not use C99 // comments

src/test/test_group.c:54:
(style) do not use C99 // comments

src/include/cart/api.h:1718:
(style) line over 80 characters

src/test/no_pmix_group_version.c:284:
(style) do not use C99 // comments

src/test/no_pmix_corpc_errors.c:288:
(style) do not use C99 // comments

src/test/tests_common.h:473:
(style) do not use C99 // comments

src/cart/crt_hg.c:882:
(style) line over 80 characters

src/cart/crt_hg.c:879:
(style) line over 80 characters

src/test/test_multi_prov_srv.c:193:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:194:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:292:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:311:
(style) Block comments use * on subsequent lines

src/test/test_multi_prov_srv.c:289:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:265:
(style) void function return statements are not generally useful

src/test/test_multi_prov_srv.c:202:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:203:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:173:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:174:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:239:
(style) Missing a blank line after declarations

src/test/test_multi_prov_srv.c:176:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:183:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:184:
(style) do not use C99 // comments

src/test/test_multi_prov_srv.c:60:
(style) macros should not use a trailing semicolon

src/test/test_multi_prov_srv.c:318:
(style) Block comments use * on subsequent lines

daosbuild1 · 2020-03-06T00:20:28Z

 	D_DEBUG(DB_ALL, "set cg_share_na %d, cg_ctx_max_num %d.\n",
-		crt_gdata.cg_share_na, crt_gdata.cg_ctx_max_num);
-	if (crt_gdata.cg_share_na == false && crt_gdata.cg_ctx_max_num > 1)
+		crt_gdata.cg_share_na[na_type], crt_gdata.cg_ctx_max_num[na_type]);


(style) line over 80 characters

daosbuild1 · 2020-03-06T00:20:28Z

-		crt_gdata.cg_share_na, crt_gdata.cg_ctx_max_num);
-	if (crt_gdata.cg_share_na == false && crt_gdata.cg_ctx_max_num > 1)
+		crt_gdata.cg_share_na[na_type], crt_gdata.cg_ctx_max_num[na_type]);
+	if (crt_gdata.cg_share_na[na_type] == false && crt_gdata.cg_ctx_max_num[na_type] > 1)


(style) line over 80 characters

daosbuild1 · 2020-03-06T00:20:28Z


 		if (crt_is_service() && crt_gdata.cg_swim_inited)
 			crt_swim_fini();
+//		if (crt_is_service())


(style) do not use C99 // comments

daosbuild1 · 2020-03-06T00:20:28Z


 		if (crt_is_service() && crt_gdata.cg_auto_swim_disable == 0) {
-			rc = crt_swim_init(CRT_DEFAULT_PROGRESS_CTX_IDX);
+			rc = crt_swim_init(na_type, CRT_DEFAULT_PROGRESS_CTX_IDX);


(style) line over 80 characters

daosbuild1 · 2020-03-06T00:20:28Z

 		D_GOTO(out, rc = -DER_PROTO);
 	}

+	// x2682 what happens if OFI_PORT is not provided?


(style) do not use C99 // comments

daosbuild1 · 2020-03-06T00:20:31Z

-			D_GOTO(out, rc = -DER_OOG);
-		}
+		for (na_type = 0; na_type < CRT_NA_TYPE_NUM; na_type++) {
+			rlink = d_hash_rec_find(&grp_priv->gp_uri_lookup_cache[na_type],


(style) line over 80 characters

daosbuild1 · 2020-03-06T00:20:32Z

+			rlink = d_hash_rec_find(&grp_priv->gp_uri_lookup_cache[na_type],
+					(void *)&rank, sizeof(rank));
+			if (!rlink) {
+				D_ERROR("Rank %d is not part of the group\n", rank);


(style) line over 80 characters

daosbuild1 · 2020-03-06T00:20:32Z

+	crt_self_uri_get_na(na_type, ctx_idx, &addr);
+
+	grpid = grp_priv->gp_pub.cg_grpid;
+	filename = crt_grp_attach_info_filename_v2(grp_priv, prov, grp_priv->gp_self);


(style) line over 80 characters

daosbuild1 · 2020-03-06T00:20:32Z

+	int			 rc;
+	int			 rc2;

+	// x2682 should be local context num. it counts how many cart contexts I


(style) do not use C99 // comments

daosbuild1 · 2020-03-06T00:20:32Z

+	int			 rc2;

+	// x2682 should be local context num. it counts how many cart contexts I
+	// have.


(style) do not use C99 // comments

daosbuild1 · 2020-03-06T00:20:37Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/45/log

daosbuild1 · 2020-03-06T00:22:47Z

Test stage Build RPM on Leap 15 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/265/log

daosbuild1 · 2020-03-06T00:24:50Z

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/268/log

daosbuild1 · 2020-03-06T00:25:16Z

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/231/log

daosbuild1 · 2020-03-06T00:26:07Z

Test stage Build on CentOS 7 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/297/log

daosbuild1 · 2020-03-06T00:26:12Z

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/266/log

daosbuild1 · 2020-03-06T00:27:53Z

Test stage Build on Leap 15 with Intel-C completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-128/19/execution/node/267/log

daosbuild1 previously requested changes Apr 25, 2019

View reviewed changes

yulujia force-pushed the yulujia/multi-prov-two-if branch from 6f9311e to cd2ad9d Compare April 25, 2019 23:58

daosbuild1 previously requested changes Apr 25, 2019

View reviewed changes

daosbuild1 previously requested changes Apr 26, 2019

View reviewed changes

yulujia force-pushed the yulujia/multi-prov-two-if branch from 555d786 to 9e456ea Compare April 29, 2019 22:36

daosbuild1 previously requested changes Apr 29, 2019

View reviewed changes

daosbuild1 previously requested changes Aug 20, 2019

View reviewed changes

daosbuild1 previously requested changes Sep 6, 2019

View reviewed changes

yulujia force-pushed the yulujia/multi-prov-two-if branch from cff8c2e to ca9e0a3 Compare March 6, 2020 00:17

daosbuild1 suggested changes Mar 6, 2020

View reviewed changes


		struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 };

		#define CRT_ISEQ_TEST_PING_CHECK /* input fields */ \

Conversation

yulujia commented Apr 25, 2019

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daosbuild1 commented Apr 25, 2019

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daosbuild1 commented Apr 25, 2019

Uh oh!

daosbuild1 commented Apr 26, 2019

Uh oh!

daosbuild1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daosbuild1 commented Apr 26, 2019

Uh oh!

daosbuild1 commented Apr 26, 2019

Uh oh!

daosbuild1 commented Apr 26, 2019

Uh oh!

daosbuild1 commented Apr 26, 2019

Uh oh!

daosbuild1 commented Apr 26, 2019

Uh oh!