Conversation
Signed-off-by: Yulu Jia <yulu.jia@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-259/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
| test.t_sub_group = crt_group_lookup("example_grpid"); | ||
| D_ASSERT(test.t_sub_group != NULL); | ||
| rc = crt_rank_evict(test.t_local_group, rpc_req_input->rank); | ||
| // test.t_sub_group = crt_group_lookup("example_grpid"); |
There was a problem hiding this comment.
(style) do not use C99 // comments
| D_ASSERTF((cb_info->cci_rc == -DER_MISMATCH || | ||
| cb_info->cci_rc == -DER_NONEXIST), | ||
| D_ASSERTF((cb_info->cci_rc == -DER_MISMATCH), | ||
| // || cb_info->cci_rc == -DER_NONEXIST), |
There was a problem hiding this comment.
(style) do not use C99 // comments
| if (test.t_sub_group == NULL) | ||
| DBG_PRINT("!!!!!!!! t_sub_group shuold not be NULL\n"); | ||
| D_ASSERTF(test.t_sub_group != NULL, "should not be NULL\n"); | ||
| // rc = crt_rank_evict(test.t_primary_group, rpc_req_input->rank); |
There was a problem hiding this comment.
(style) do not use C99 // comments
| rc = test_rank_evict(test.t_primary_group, test.t_crt_ctx, | ||
| 2); | ||
| if (rc != DER_SUCCESS) | ||
| D_ERROR("crt_rank_evcit(grp=%p, rank=2) failed, rc %d\n", |
There was a problem hiding this comment.
(style) line over 80 characters
| return -DER_INVAL; | ||
|
|
||
| excluded_membs.rl_nr = 3; | ||
| // excluded ranks contains secondary logical ranks |
There was a problem hiding this comment.
(style) do not use C99 // comments
| if (rc != DER_SUCCESS) | ||
| D_ERROR("crt_rank_evcit(grp=%p, rank=2) failed, rc %d\n", | ||
| test.t_local_group, rc); | ||
| // rc = crt_rank_evict(test.t_primary_group, 2); |
There was a problem hiding this comment.
(style) do not use C99 // comments
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/44/log |
|
Test stage Build RPM on Leap 15 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/260/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/257/log |
|
Test stage Build on SLES 12.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/268/log |
|
Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/284/log |
|
Test stage Build on Leap 42.3 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/1/execution/node/350/log |
Signed-off-by: Yulu Jia <yulu.jia@intel.com>
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/2/execution/node/288/log |
|
Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-259/3/execution/node/290/log |
2 participants
Signed-off-by: Yulu Jia yulu.jia@intel.com