Conversation
launch two ranks, rank A sends an RPC to a live rank B. Cancel it before receiving the reply. both ranks should shutdown cleanly. Signed-off-by: Yulu Jia <yulu.jia@intel.com>
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-297/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
| void | ||
| test_checkin_handler(crt_rpc_t *rpc_req) | ||
| { | ||
| // x2682 add a 60s delay, and set the global timeout to 5 seconds |
There was a problem hiding this comment.
(style) do not use C99 // comments
| ((d_string_t) (name) CRT_VAR) \ | ||
| ((bool) (bool_val) CRT_VAR) | ||
|
|
||
| #define CRT_OSEQ_TEST_PING_CHECK /* output fields */ \ |
There was a problem hiding this comment.
(style) Macros with complex values should be enclosed in parentheses
| } | ||
| } | ||
|
|
||
| void crt_swim_disable_all(void); |
There was a problem hiding this comment.
(style) externs should be avoided in .c files
|
|
||
| struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 }; | ||
|
|
||
| #define CRT_ISEQ_TEST_PING_CHECK /* input fields */ \ |
There was a problem hiding this comment.
(style) Macros with complex values should be enclosed in parentheses
| # -x FI_LOG_LEVEL=debug \ | ||
|
|
||
| (orterun --mca mtl ^psm2,ofi --enable-recovery \ | ||
| --output-filename $PWD/logs/live-rank \ |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| export PATH=./install/Linux/TESTING/tests/:$PATH | ||
| set -ex | ||
|
|
||
| mkdir -p $PWD/logs/live-rank |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| set -ex | ||
|
|
||
| mkdir -p $PWD/logs/live-rank | ||
| rm -rf $PWD/logs/live-rank/* |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| --output-filename $PWD/logs/live-rank \ | ||
| --report-uri ~/uri.txt \ | ||
| -x CRT_TIMEOUT=5 \ | ||
| -x D_LOG_FILE=$PWD/logs/test-cancel-rpc-to-live-rank.log \ |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| -x CRT_CTX_NUM=2 \ | ||
| -np 2 \ | ||
| ./install/Linux/TESTING/tests/test_cancel_rpc_to_live_rank \ | ||
| --name service-group --is_service --c 2) |
There was a problem hiding this comment.
(style) trailing whitespace
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-297/1/execution/node/44/log |
daosbuild1
left a comment
daosbuild1
left a comment
There was a problem hiding this comment.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-297/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
| void | ||
| test_checkin_handler(crt_rpc_t *rpc_req) | ||
| { | ||
| // x2682 add a 60s delay, and set the global timeout to 5 seconds |
There was a problem hiding this comment.
(style) do not use C99 // comments
| ((d_string_t) (name) CRT_VAR) \ | ||
| ((bool) (bool_val) CRT_VAR) | ||
|
|
||
| #define CRT_OSEQ_TEST_PING_CHECK /* output fields */ \ |
There was a problem hiding this comment.
(style) Macros with complex values should be enclosed in parentheses
| } | ||
| } | ||
|
|
||
| void crt_swim_disable_all(void); |
There was a problem hiding this comment.
(style) externs should be avoided in .c files
|
|
||
| struct test_t test_g = { .t_hold_time = 0, .t_ctx_num = 1, .t_roomno = 1082 }; | ||
|
|
||
| #define CRT_ISEQ_TEST_PING_CHECK /* input fields */ \ |
There was a problem hiding this comment.
(style) Macros with complex values should be enclosed in parentheses
| # -x FI_LOG_LEVEL=debug \ | ||
|
|
||
| (orterun --mca mtl ^psm2,ofi --enable-recovery \ | ||
| --output-filename $PWD/logs/live-rank \ |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| export PATH=./install/Linux/TESTING/tests/:$PATH | ||
| set -ex | ||
|
|
||
| mkdir -p $PWD/logs/live-rank |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| set -ex | ||
|
|
||
| mkdir -p $PWD/logs/live-rank | ||
| rm -rf $PWD/logs/live-rank/* |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| --output-filename $PWD/logs/live-rank \ | ||
| --report-uri ~/uri.txt \ | ||
| -x CRT_TIMEOUT=5 \ | ||
| -x D_LOG_FILE=$PWD/logs/test-cancel-rpc-to-live-rank.log \ |
There was a problem hiding this comment.
(lint) Double quote to prevent globbing and word splitting. [SC2086]
| -x CRT_CTX_NUM=2 \ | ||
| -np 2 \ | ||
| ./install/Linux/TESTING/tests/test_cancel_rpc_to_live_rank \ | ||
| --name service-group --is_service --c 2) |
There was a problem hiding this comment.
(style) trailing whitespace
|
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-297/2/execution/node/44/log |
2 participants
launch two ranks, rank A sends an RPC to a live rank B. Cancel it before
receiving the reply. both ranks should shutdown cleanly.