Skip to content
This repository was archived by the owner on Dec 2, 2021. It is now read-only.

DAOS-4762 build: Improvements for GA supportability#400

Open
brianjmurrell wants to merge 2 commits intomasterfrom
bmurrell/1.0-release-improvements
Open

DAOS-4762 build: Improvements for GA supportability#400
brianjmurrell wants to merge 2 commits intomasterfrom
bmurrell/1.0-release-improvements

Conversation

@brianjmurrell
Copy link
Copy Markdown
Contributor

@brianjmurrell brianjmurrell commented May 8, 2020

Several improvements to enhance supportability of DAOS 1.0 once it's
released:

Signed-off-by: Brian J. Murrell brian.murrell@intel.com

Copy link
Copy Markdown
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread utils/rpms/cart.spec Outdated
Comment thread utils/rpms/cart.spec Outdated
Comment thread utils/rpms/cart.spec Outdated
@daosbuild1
Copy link
Copy Markdown
Collaborator

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Build RPM on Leap 15 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-400/3/execution/node/261/log

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-400/3/execution/node/257/log

@daosbuild1 daosbuild1 dismissed their stale review May 8, 2020 18:21

Updated patch

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Build RPM on Leap 15 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-400/4/execution/node/266/log

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-400/4/execution/node/257/log

@brianjmurrell brianjmurrell force-pushed the bmurrell/1.0-release-improvements branch from ac28758 to afbd3ba Compare May 8, 2020 18:38
@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Build RPM on Leap 15 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-400/5/execution/node/257/log

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Build RPM on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/cart/view/change-requests/job/PR-400/5/execution/node/258/log

@brianjmurrell brianjmurrell self-assigned this May 9, 2020
@brianjmurrell brianjmurrell force-pushed the bmurrell/1.0-release-improvements branch from eeb8bf3 to 47eb230 Compare May 9, 2020 10:27
@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Single-node completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-400/8/display/redirect

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Single-node-valgrind completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-400/8/display/redirect

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Two-node completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-400/8/display/redirect

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Three-node completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-400/8/display/redirect

@daosbuild1
Copy link
Copy Markdown
Collaborator

Test stage Five-node completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/cart/job/PR-400/8/display/redirect

Several improvements to enhance supportability of DAOS 1.0 once it's
released:
- remove libfabric requirement as that's mercury's job
- require mercury to be < 2.0.0a1 as that was an improper way of
  specifying a pre-release
  - would prefer to set a minimum version also however
    rpm-software-management/yum#124

PR-repos: mercury@PR-44
Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell brianjmurrell force-pushed the bmurrell/1.0-release-improvements branch from 47eb230 to 249dc52 Compare May 9, 2020 15:07
frostedcmos
frostedcmos previously approved these changes May 11, 2020
JohnMalmberg
JohnMalmberg previously approved these changes May 11, 2020
@brianjmurrell brianjmurrell changed the title CART-89 build: Improvements for GA supportability DAOS-4762 build: Improvements for GA supportability May 11, 2020
@jolivier23
Copy link
Copy Markdown
Contributor

The ticket isn't on the rc1 list

@brianjmurrell
Copy link
Copy Markdown
Contributor Author

The ticket isn't on the rc1 list

Correct. I am still waiting for one more approval vote from @johannlombardi. I will request review from the gatekeeper if/when I get it. There will of course be a corresponding daos PR if I do get approval.

jolivier23
jolivier23 previously approved these changes May 13, 2020
Copy link
Copy Markdown
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to remove from my list until it gets approved and you add gatekeeper

Comment thread utils/rpms/cart.spec
BuildRequires: libfabric-devel
BuildRequires: openpa-devel
BuildRequires: mercury-devel = %{mercury_version}
BuildRequires: mercury-devel < 2.0.0a1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there's a lot of flip-flopping between using the macro version and hard-coding it... Maybe I don't understand the relationship between the PRs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, because the concept with the macro was that it was an exact version but now we are migrating to any version less than. I don't want people mistakingly continuing to populate the macro as an exact version when it's actually being used as a less than as the results would be not at all what they are looking for.

This really is just a 1.0 branch issue, for future supportability.

…e-improvements

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants