check if 80 and 443 ports are used & https running#686
Open
check if 80 and 443 ports are used & https running#686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to fix issue #684
is_port_used()function to check both ports 80 and 443, and to only setIS_PORT_USED=trueif those ports are used andDAppNodeCore-https.dnp.dappnode.ethcontainer is not running.Important: We could, but we do not explicitly check that the
DAppNodeCore-https.dnp.dappnode.ethcontainer is the one using these ports. We suppose it is if 80 or 443 are used and HTTPS is running.