Skip to content

fix flaky standalone e2e by dropping "Exited App successfully" requirement#1605

Open
acroca wants to merge 5 commits intodapr:masterfrom
acroca:fix-flaky-e2e
Open

fix flaky standalone e2e by dropping "Exited App successfully" requirement#1605
acroca wants to merge 5 commits intodapr:masterfrom
acroca:fix-flaky-e2e

Conversation

@acroca
Copy link
Member

@acroca acroca commented Mar 6, 2026

An example of the flakiness here https://github.com/dapr/cli/actions/runs/22751141926/job/65985748435?pr=1604

Fix flaky standalone e2e tests by simplifying the exit-error check in executeAgainstRunningDapr.

…ement

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce flakiness in standalone E2E tests by simplifying the “clean exit” logic in executeAgainstRunningDapr, removing the requirement that output must contain Exited App successfully.

Changes:

  • Simplifies the cmd.Wait() error handling by dropping the hasAppCommand / Exited App successfully gating logic.
  • Updates exit-validation to instead rely on absence of an “App process exited with error…” message.
  • Removes the conditional assertion for Exited App successfully from the helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@acroca acroca marked this pull request as ready for review March 6, 2026 13:01
@acroca acroca requested review from a team as code owners March 6, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants