Skip to content

feat: Add aio module and update mypy configuration to include aio files#942

Merged
sicoyle merged 1 commit intodapr:mainfrom
acroca:fix-aio-mypy
Mar 9, 2026
Merged

feat: Add aio module and update mypy configuration to include aio files#942
sicoyle merged 1 commit intodapr:mainfrom
acroca:fix-aio-mypy

Conversation

@acroca
Copy link
Member

@acroca acroca commented Mar 6, 2026

This change should fix the mypy issue where we have to ignore some checks when importing the aio client ``.

@acroca acroca requested review from a team as code owners March 6, 2026 06:41
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.89%. Comparing base (bffb749) to head (5e6d3c7).
⚠️ Report is 86 commits behind head on main.

Files with missing lines Patch % Lines
dapr/aio/clients/grpc/client.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   86.63%   86.89%   +0.26%     
==========================================
  Files          84      103      +19     
  Lines        4473     7305    +2832     
==========================================
+ Hits         3875     6348    +2473     
- Misses        598      957     +359     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acroca
Copy link
Member Author

acroca commented Mar 6, 2026

I tried improving the coverage but it'd require adding test for deprecated operations. I've started #943 so in theory after removing the deprecations the coverage should get better.

Copy link
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@sicoyle sicoyle merged commit 8589d2e into dapr:main Mar 9, 2026
25 of 27 checks passed
dapr-bot pushed a commit that referenced this pull request Mar 9, 2026
…es (#942)

Signed-off-by: Albert Callarisa <albert@diagrid.io>
(cherry picked from commit 8589d2e)
@acroca acroca deleted the fix-aio-mypy branch March 10, 2026 10:26
acroca added a commit that referenced this pull request Mar 10, 2026
…es (#942) (#948)

(cherry picked from commit 8589d2e)

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Co-authored-by: Albert Callarisa <albert@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants