Fix runtime error call stacks to show function names instead of UUIDs#5586
Closed
OceanOak wants to merge 1 commit intodarklang:mainfrom
Closed
Fix runtime error call stacks to show function names instead of UUIDs#5586OceanOak wants to merge 1 commit intodarklang:mainfrom
OceanOak wants to merge 1 commit intodarklang:mainfrom
Conversation
Member
|
Is this still relevant/ I think so, but needs update given changes since. At the time this PR was made, I was hesitant to merge because of |
Collaborator
Author
|
This is no longer relevant. We now use hashes for package function references, and the call stack resolution already maps them back to function names. I tested this by triggering a runtime error in the CLI, the error output correctly shows function names instead of hashes. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.