Various fixes and maintenance#20811
Merged
TurboGit merged 5 commits intodarktable-org:masterfrom Apr 15, 2026
Merged
Conversation
jenshannoschwalm
added
bugfix
Collaborator
|
You probably know this already, but it's also possible to add someone beside yourself as (co)author of a commit, which preserves attribution in things like |
1. Rename kernel code to be equivalent for CPU and OpenCL also with other implementations.
2. minor improvements
3. The relevant part is the clipping for VH/PQ dirs while mixing.
As we don't have fully-normalized data the PQ values can be above 1 resulting in some
- (very subtle) overshoots in bright areas
- diffs between OpenCL and CPU code because of compiler flags and OpenCL mix() undefined
for mixers outside the 0->1 range.
The amount of diffs may be up to 1e-6 for signals in the range of ~1.0 so no need to
revamp module version.
1. some use of PI float representation 2. more use of dt_fast_hypot() 3. some square instead of powf() 4. some sinf/cosf instead of sin/cos where correct
Fixes a bug leading to wrong data for full VNG/VNG4 demosaicing in dark areas.
jenshannoschwalm
force-pushed
the
various_fixes_and_maintenance
branch
from
07c7c96 to
549497f
Compare
Taken from ansel code ... Step 1.1 + 1.2: preload one CFA tile and derive the directional discrimination locally so we avoid materializing two full-frame high-pass buffers in global memory.
Calling kernel with dt interface
jenshannoschwalm
force-pushed
the
various_fixes_and_maintenance
branch
from
549497f to
f4305ed
Compare
Collaborator
Author
|
@TurboGit fixed copyrighting as you suggested. Ok to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TurboGit
0048is now working ok and should get the cpu/gpu diffs and expected image updated (The cpu code was not only slower but just wrong).