This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Strips comments from css before applying css shim.#1738
Open
winstonewert wants to merge 1 commit intodart-archive:masterfrom
Open
Strips comments from css before applying css shim.#1738winstonewert wants to merge 1 commit intodart-archive:masterfrom
winstonewert wants to merge 1 commit intodart-archive:masterfrom
Conversation
As it stands, the CSS comments confuse the parser's ability to recognize the polyfill-non-strict and friends, as the comments get treated as part of the selector. This simply strips out the comments before doing any processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it stands, the CSS comments confuse the parser's ability to recognize
the polyfill-non-strict and friends, as the comments get treated as part
of the selector. This simply strips out the comments before doing any
processing.