Add package config file generation for find_package#106
Add package config file generation for find_package#106a-pekar wants to merge 1 commit intodascandy:cpp11from
Conversation
a-pekar
force-pushed
the
cpp11
branch
4 times, most recently
from
a2c41ba to
9f5ae9e
Compare
|
Please, review. Travis build seems to have failed for some irrelevant reason |
|
Travis build fails on Travis CI no longer being able to find the Clang-3.7 package for their majorly outdated Linux deployment - probably because it's gone out of LTS support a few years ago. I'll check if I can move it to more up to date Clangs and distros. No worries, none of your code was even looked at in the failed build, and all builds that were run are successful. |
| if (NOT WIN32) | ||
| target_compile_options(HippoMocks | ||
| INTERFACE | ||
| -Wall -Wextra -pedantic -Wno-long-long -std=c++11 |
There was a problem hiding this comment.
This could lead to build failures if project is built once and used on different platforms (which is a possiblility given that it's header-only). Consider moving flags to HippoMocksTest project instead (where they are useful) to avoid forcing them on other people, and setting CXX_STANDARD + CXX_STANDARD_REQUIRED properties here instead of -std=c++11.
There was a problem hiding this comment.
This needs to be a cxx_std_11 compile feature since aforementioned properties aren't supported on interface targets :(
a-pekar
force-pushed
the
cpp11
branch
4 times, most recently
from
31a9bd3 to
a2615f5
Compare
- no package config version file - moved compile options to test project - added opportunity to skip tests
4 participants
(without package config version file)