Add hover focus ring with modifier-based parent targeting#2
Open
Add hover focus ring with modifier-based parent targeting#2
Conversation
…rames Adds a visible outline ring when hovering frames and text nodes on the canvas, with Cmd/Ctrl modifier support to promote the hover target to the nearest parent frame. Clicking while the modifier is held selects the promoted parent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When Cmd/Ctrl is held and a frame is selected, the hover ring now promotes from the selected frame to its parent rather than from the deepest hovered frame. This allows reliable upward targeting in deeply nested structures where children share identical bounds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointermovehandler with DOM walking for robust hit-testing across nested and overlapping framesDetails
New file:
hover-ring.svelteLightweight overlay component — positioned via
getBoundingClientRectmath,pointer-events-none, rendered below selection overlay (z-5 vs z-10).EditorState changes:
#deepHoveredNodeIdtracks the deepest hovered node from pointer movement#modifierHeldtracks Cmd/Ctrl key state#displayedHoveredNodeId(derived) promotes to parent frame when modifier is held, falls back to deep target if no eligible parent existsisHoverableNode(id)— checks node is a frame or text and visibleCanvas changes:
pointermovewalks DOM frome.targetupward to find nearest[data-id]element passingisHoverableNodeonblurfallbackspaceHeld) and when hovering the selected nodeTest plan
🤖 Generated with Claude Code