Skip to content

refactor: rename Dash network entries to Mainnet #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xdustinface wants to merge 1 commit into
base: v0.42-dev
Choose a base branch
from
+350 −343

refactor: rename `Dash` network entries to `Mainnet`

faa0edd
Select commit
Loading
Failed to load commit list.
Open

refactor: rename Dash network entries to Mainnet #500

refactor: rename `Dash` network entries to `Mainnet`
faa0edd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 11, 2026 in 1s

66.89% (+0.03%) compared to 8bca47d

View this Pull Request on Codecov

66.89% (+0.03%) compared to 8bca47d

Details

Codecov Report

❌ Patch coverage is 72.77228% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.89%. Comparing base (8bca47d) to head (faa0edd).
⚠️ Report is 2 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
dash/src/address.rs 67.64% 11 Missing ⚠️
key-wallet/src/bip38.rs 0.00% 9 Missing ⚠️
key-wallet/src/derivation_slip10.rs 16.66% 5 Missing ⚠️
key-wallet/src/bip32.rs 92.30% 4 Missing ⚠️
dash-spv-ffi/src/platform_integration.rs 0.00% 3 Missing ⚠️
key-wallet-ffi/src/account.rs 0.00% 3 Missing ⚠️
key-wallet/src/account/account_type.rs 40.00% 3 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 2 Missing ⚠️
dash-spv-ffi/src/config.rs 0.00% 2 Missing ⚠️
dash-spv/src/network/discovery.rs 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #500      +/-   ##
=============================================
+ Coverage      66.86%   66.89%   +0.03%     
=============================================
  Files            313      313              
  Lines          64756    64757       +1     
=============================================
+ Hits           43299    43322      +23     
+ Misses         21457    21435      -22
Files with missing lines Coverage Δ
dash-spv/src/chain/chain_work.rs 77.86% <100.00%> (ø)
dash-spv/src/client/config.rs 92.45% <100.00%> (ø)
dash-spv/src/client/config_test.rs 100.00% <100.00%> (ø)
dash-spv/src/mempool_filter.rs 84.64% <100.00%> (ø)
dash-spv/src/validation/header.rs 95.95% <100.00%> (ø)
dash/src/blockdata/constants.rs 100.00% <100.00%> (ø)
dash/src/blockdata/transaction/mod.rs 86.15% <100.00%> (ø)
dash/src/blockdata/transaction/outpoint.rs 77.50% <ø> (ø)
dash/src/crypto/key.rs 76.33% <100.00%> (ø)
dash/src/crypto/sighash.rs 65.27% <100.00%> (ø)
... and 28 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov