Skip to content

chore: make codecov/project wait for all uploads#508

Merged
xdustinface merged 1 commit intov0.42-devfrom
chore/codecov-wait
Mar 10, 2026
Merged

chore: make codecov/project wait for all uploads#508
xdustinface merged 1 commit intov0.42-devfrom
chore/codecov-wait

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Mar 10, 2026

The default wait_for_ci doesn't seem to do its job properly.. since the codecov/project action currently races to false after the first uploads it seems. Even though it recovers once all uploads were done, with this change it just waits for the reporting until all uploads are done.

Summary by CodeRabbit

  • Chores
    • Updated code coverage notification configuration to adjust notification timing and align with the coverage upload schedule.

The default `wait_for_ci` doesn't seem to do its job properly.. since the `codecov/project` action currently races to false after the first uploads it seems. Even though it recovers once all uploads were done, with this change it just waits for the reporting until all uploads are done.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f2d65a74-07f2-4294-8ce8-b74267f4f1e6

📥 Commits

Reviewing files that changed from the base of the PR and between 98988cc and 7fd2153.

📒 Files selected for processing (1)
  • .codecov.yml

📝 Walkthrough

Walkthrough

Added a configuration setting to .codecov.yml specifying that Codecov notifications should be emitted after five builds. The new codecov.notify.after_n_builds: 5 parameter aligns notification timing with the number of coverage-uploading groups in the project.

Changes

Cohort / File(s) Summary
Codecov Configuration
.codecov.yml
Added notify.after_n_builds: 5 configuration parameter with a comment indicating it should match the number of coverage-uploading groups.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Five builds now before we notify,
A timing tweak, simple and tidy,
Coverage groups align with grace,
Config perfection in its place! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: configuring codecov to wait for all uploads before reporting, which matches the PR objective of ensuring codecov/project waits for all coverage uploads.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/codecov-wait

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.87%. Comparing base (b1451dc) to head (7fd2153).
⚠️ Report is 4 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #508      +/-   ##
=============================================
+ Coverage      66.85%   66.87%   +0.01%     
=============================================
  Files            313      313              
  Lines          64775    64775              
=============================================
+ Hits           43306    43317      +11     
+ Misses         21469    21458      -11     
Flag Coverage Δ *Carryforward flag
core 74.93% <ø> (ø)
dash-network 74.92% <ø> (ø) Carriedforward from b1451dc
dash-network-ffi 34.74% <ø> (ø) Carriedforward from b1451dc
dash-spv 68.18% <ø> (ø) Carriedforward from b1451dc
dash-spv-ffi 34.74% <ø> (ø) Carriedforward from b1451dc
dashcore 74.92% <ø> (ø) Carriedforward from b1451dc
dashcore-private 74.92% <ø> (ø) Carriedforward from b1451dc
dashcore-rpc 19.92% <ø> (ø) Carriedforward from b1451dc
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from b1451dc
dashcore_hashes 74.92% <ø> (ø) Carriedforward from b1451dc
ffi 35.98% <ø> (+0.01%) ⬆️
key-wallet 65.69% <ø> (ø) Carriedforward from b1451dc
key-wallet-ffi 34.74% <ø> (ø) Carriedforward from b1451dc
key-wallet-manager 65.69% <ø> (ø) Carriedforward from b1451dc
rpc 19.92% <ø> (ø)
spv 81.03% <ø> (+0.07%) ⬆️
wallet 65.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xdustinface xdustinface requested a review from ZocoLini March 10, 2026 15:51
@xdustinface xdustinface merged commit 1d4e6e5 into v0.42-dev Mar 10, 2026
53 checks passed
@xdustinface xdustinface deleted the chore/codecov-wait branch March 10, 2026 17:03
ZocoLini pushed a commit that referenced this pull request Mar 10, 2026
The default `wait_for_ci` doesn't seem to do its job properly.. since the `codecov/project` action currently races to false after the first uploads it seems. Even though it recovers once all uploads were done, with this change it just waits for the reporting until all uploads are done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants