refactor: remove current_sync_peer from network manager

[xdustinface]

Simplify peer selection in send_to_single_peer by removing the sticky sync peer tracking. Peers are now selected directly based on message type requirements and the round-robin counter.

Based on:

• refactor: extract capability lookup into PeerPool helpers #509

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d525bf7-598d-4938-8fb0-d0f79fac31ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/drop-current-sync-peer

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.95%. Comparing base (bbaf01d) to head (f2fe73b).

Files with missing lines	Patch %	Lines
dash-spv/src/network/manager.rs	50.00%	10 Missing ⚠️

Additional details and impacted files

@@                       Coverage Diff                        @@
##           refactor/peer-service-lookup     #511      +/-   ##
================================================================
+ Coverage                         66.90%   66.95%   +0.05%     
================================================================
  Files                               313      313              
  Lines                             64835    64795      -40     
================================================================
+ Hits                              43376    43383       +7     
+ Misses                            21459    21412      -47     

Flag	Coverage Δ		*Carryforward flag
core	74.93% <ø> (ø)
dash-network	74.92% <ø> (ø)		Carriedforward from bbaf01d
dash-network-ffi	34.74% <ø> (ø)		Carriedforward from bbaf01d
dash-spv	68.68% <ø> (+0.26%)	⬆️	Carriedforward from bbaf01d
dash-spv-ffi	34.74% <ø> (ø)		Carriedforward from bbaf01d
dashcore	74.92% <ø> (ø)		Carriedforward from bbaf01d
dashcore-private	74.92% <ø> (ø)		Carriedforward from bbaf01d
dashcore-rpc	19.92% <ø> (ø)		Carriedforward from bbaf01d
dashcore-rpc-json	19.92% <ø> (ø)		Carriedforward from bbaf01d
dashcore_hashes	74.92% <ø> (ø)		Carriedforward from bbaf01d
ffi	35.98% <ø> (ø)
key-wallet	65.69% <ø> (ø)		Carriedforward from bbaf01d
key-wallet-ffi	34.74% <ø> (ø)		Carriedforward from bbaf01d
key-wallet-manager	65.69% <ø> (ø)		Carriedforward from bbaf01d
rpc	19.92% <ø> (ø)
spv	81.44% <50.00%> (+0.32%)	⬆️
wallet	65.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
dash-spv/src/network/manager.rs	61.52% <50.00%> (+3.83%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.