Skip to content

chore(key-wallet): removed hkdf dependency#512

Merged
xdustinface merged 1 commit intov0.42-devfrom
chore/drop-hkdf-dep
Mar 10, 2026
Merged

chore(key-wallet): removed hkdf dependency#512
xdustinface merged 1 commit intov0.42-devfrom
chore/drop-hkdf-dep

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Mar 10, 2026

Summary by CodeRabbit

  • Chores
    • Removed unused dependency from project configuration.

@ZocoLini ZocoLini requested a review from xdustinface March 10, 2026 17:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cb4b373-670b-481b-bc6d-9f911efa3cda

📥 Commits

Reviewing files that changed from the base of the PR and between 8bca47d and bd81c10.

📒 Files selected for processing (1)
  • key-wallet/Cargo.toml
💤 Files with no reviewable changes (1)
  • key-wallet/Cargo.toml

📝 Walkthrough

Walkthrough

Removed the hkdf dependency from key-wallet/Cargo.toml. This is a straightforward dependency cleanup with no functional code changes affecting the project.

Changes

Cohort / File(s) Summary
Dependency Cleanup
key-wallet/Cargo.toml
Removed hkdf dependency entry from the [dependencies] section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 One less dependency to carry,
Lighter loads, no need to tarry,
Hkdf takes its final bow,
Cleaner Cargo files now! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the hkdf dependency from the key-wallet crate's Cargo.toml file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/drop-hkdf-dep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.81%. Comparing base (98988cc) to head (bd81c10).
⚠️ Report is 8 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #512      +/-   ##
=============================================
- Coverage      66.86%   66.81%   -0.05%     
=============================================
  Files            313      313              
  Lines          64775    64756      -19     
=============================================
- Hits           43314    43269      -45     
- Misses         21461    21487      +26     
Flag Coverage Δ *Carryforward flag
core 74.93% <ø> (ø)
dash-network 74.92% <ø> (ø) Carriedforward from 98988cc
dash-network-ffi 34.74% <ø> (ø) Carriedforward from 98988cc
dash-spv 68.29% <ø> (+0.10%) ⬆️ Carriedforward from 98988cc
dash-spv-ffi 34.74% <ø> (ø) Carriedforward from 98988cc
dashcore 74.92% <ø> (ø) Carriedforward from 98988cc
dashcore-private 74.92% <ø> (ø) Carriedforward from 98988cc
dashcore-rpc 19.92% <ø> (ø) Carriedforward from 98988cc
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from 98988cc
dashcore_hashes 74.92% <ø> (ø) Carriedforward from 98988cc
ffi 35.24% <ø> (-0.75%) ⬇️
key-wallet 65.69% <ø> (ø) Carriedforward from 98988cc
key-wallet-ffi 34.74% <ø> (ø) Carriedforward from 98988cc
key-wallet-manager 65.69% <ø> (ø) Carriedforward from 98988cc
rpc 19.92% <ø> (ø)
spv 81.12% <ø> (+0.11%) ⬆️
wallet 65.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xdustinface xdustinface merged commit 9959201 into v0.42-dev Mar 10, 2026
55 checks passed
@xdustinface xdustinface deleted the chore/drop-hkdf-dep branch March 10, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants