fix: add items type to roles const in access-ref partner organization#24
Draft
fix: add items type to roles const in access-ref partner organization#24
Conversation
Using const: [] (non-primitive) causes AJV standalone code generation
to emit require("ajv/dist/runtime/equal") for deep equality checks,
which breaks ESM builds. maxItems: 0 is semantically equivalent and
avoids this dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roles: { type: 'array', const: [] }generatesroles?: unknown[]which works but is imprecise. Withoutitems, the TypeScript type lacks thestring[]information needed for.includes(session.accountRole)to compile correctly inindex.ts.Fix
Add
items: { type: 'string' }to therolesproperty of the partner organization variant:This generates the correct
string[]type while keeping theconst: []validation (ensuring roles is always empty for partner organizations).Note:
const: [](non-primitive) causes AJV standalone code generation to emitrequire("ajv/dist/runtime/equal"). A separate fix for that is tracked in json-layout/json-layout#9.