fix(sql): implement recursive cte hooks in lite planner ctx#19558
Merged
KKould merged 1 commit intodatabendlabs:mainfrom Mar 17, 2026
Merged
Conversation
sundy-li
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
linux / checkfailure onmaincaused byLiteTableContextmissing the new recursive CTE temp table hooks required byTableContext.Changes
add_recursive_cte_temp_tableanddrop_recursive_cte_temp_tablein the planner test fixtureLiteTableContext.m_ctetemp table helpers used by the same lightweight test context.Implementation
cargo clippy --workspace --all-targets --all-features -- -D warningswas failing becausesrc/query/sql/tests/it/planner/fixture.rsno longer implemented all requiredTableContextitems.LiteTableContext, which is sufficient for planner fixture tests.Tests
Validation commands:
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningsType of change
This change is