Skip to content

fix(sql): implement recursive cte hooks in lite planner ctx#19558

Merged
KKould merged 1 commit intodatabendlabs:mainfrom
KKould:fix/planner-lite-table-context-recursive-cte
Mar 17, 2026
Merged

fix(sql): implement recursive cte hooks in lite planner ctx#19558
KKould merged 1 commit intodatabendlabs:mainfrom
KKould:fix/planner-lite-table-context-recursive-cte

Conversation

@KKould
Copy link
Copy Markdown
Member

@KKould KKould commented Mar 17, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Fix the linux / check failure on main caused by LiteTableContext missing the new recursive CTE temp table hooks required by TableContext.

Changes

  • Added no-op implementations for add_recursive_cte_temp_table and drop_recursive_cte_temp_table in the planner test fixture LiteTableContext.
  • Kept the behavior aligned with the existing m_cte temp table helpers used by the same lightweight test context.

Implementation

  1. Located the failing GitHub Actions job: https://github.com/databendlabs/databend/actions/runs/23183524583/job/67361514317
  2. Confirmed cargo clippy --workspace --all-targets --all-features -- -D warnings was failing because src/query/sql/tests/it/planner/fixture.rs no longer implemented all required TableContext items.
  3. Added the missing recursive CTE temp table hooks as no-op methods in LiteTableContext, which is sufficient for planner fixture tests.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Pair with the reviewer to explain why

Validation commands:

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features -- -D warnings

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This change is Reviewable

@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Mar 17, 2026
@KKould KKould requested a review from forsaken628 March 17, 2026 11:54
@KKould KKould self-assigned this Mar 17, 2026
@KKould KKould requested a review from sundy-li March 17, 2026 11:54
@KKould KKould merged commit d062a80 into databendlabs:main Mar 17, 2026
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants