Implemented the functionality of pool_pre_ping #53
Open
msrathore-db wants to merge 3 commits intomainfrom
Open
Implemented the functionality of pool_pre_ping #53msrathore-db wants to merge 3 commits intomainfrom
msrathore-db wants to merge 3 commits intomainfrom
Conversation
… to see if the connection is alive. If not it'll recycle the session
|
@msrathore-db This maybe a better solution. |
…ing the default behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
is_disconnect()method to enable connection health checking and prevent "Invalid SessionHandle" errors when connections expire or are closed by the server.Closes #47
Problem
Users experienced
Invalid SessionHandleerrors when connections expired or were closed by the server. SQLAlchemy'spool_pre_ping=Truefeature wasn't working because the dialect didn'timplement
is_disconnect()to classify disconnect errors.When connections died (either before checkout or during query execution), SQLAlchemy couldn't determine if errors were due to disconnects, leaving dead connections in the pool and causing
repeated errors.
Solution
Implements
is_disconnect()method that classifies exceptions as disconnect errors, enabling both pessimistic and optimistic disconnect handling as described in SQLAlchemy's pooling documentation.How It Works