feat: Add missing newlines and add flag --no-trailing-newline port https://github.com/google/go-jsonnet/pull/843#613
Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom Feb 27, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports the --no-trailing-newline flag from upstream jsonnet implementations (google/go-jsonnet and google/jsonnet) to sjsonnet. By default, sjsonnet now adds trailing newlines to output (both stdout and files in multi mode), and the new flag allows users to suppress these trailing newlines. This brings sjsonnet's behavior in line with other jsonnet implementations.
Changes:
- Added
--no-trailing-newlineflag to suppress trailing newlines in output - Updated default behavior to add trailing newlines to multi-mode file outputs
- Added validation to prevent using the flag with
--yaml-streammode
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sjsonnet/src-jvm-native/sjsonnet/Config.scala | Adds the noTrailingNewline flag configuration parameter |
| sjsonnet/src-jvm-native/sjsonnet/SjsonnetMainBase.scala | Implements the flag logic for stdout, file writing, and yaml output; adds validation to reject the flag with yaml-stream |
| sjsonnet/test/src-jvm/sjsonnet/MainTests.scala | Updates existing tests to expect trailing newlines and adds comprehensive tests for the new flag across different output modes |
| sjsonnet/test/resources/db/multi_string.jsonnet | Adds test resource file for multi-file string output tests |
| readme.md | Documents the new --no-trailing-newline flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #592