Skip to content

Adding updated files#1918

Open
smarthg-gi wants to merge 2 commits intodatacommonsorg:masterfrom
smarthg-gi:S1502
Open

Adding updated files#1918
smarthg-gi wants to merge 2 commits intodatacommonsorg:masterfrom
smarthg-gi:S1502

Conversation

@smarthg-gi
Copy link

@smarthg-gi smarthg-gi commented Mar 16, 2026

Autorefresh for Subject table S1502

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the column mapping for US Census data. It updates the data year from 2023 to 2015 and significantly standardizes and simplifies the structure of various column keys within the mapping file. These changes improve consistency and conciseness across the data definitions.

Highlights

  • Data Year Update: Updated the target data year reference within the column_map.json file from "2023" to "2015".
  • Column Key Standardization: Standardized the format of numerous column keys by prepending "Total!!", "Males!!", or "Females!!" to their respective estimate and margin of error entries.
  • Column Key Simplification: Simplified verbose column keys by removing redundant phrases like "Total population 25 years and over with a Bachelor's degree or higher" when more specific demographic or major information was already present.
Changelog
  • scripts/us_census/acs5yr/subject_tables/s1502/testdata/column_map.json
    • Changed the root year key from "2023" to "2015".
    • Reordered and added "Total!!" prefix to general population estimate and margin of error keys.
    • Streamlined keys for specific majors (Science and Engineering, Business, Education, Arts, Humanities, and Others) by removing the redundant "Total population 25 years and over with a Bachelor's degree or higher" phrase.
    • Applied similar standardization and simplification to keys involving detailed age groups (25 to 39 years, 40 to 64 years, 65 years and over) for both total, male, and female populations across various majors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the column_map.json test data file for the S1502 subject table. The changes primarily refactor the column name keys to be more concise and consistent, for example by standardizing on plural gender names (Males, Females) and removing redundant descriptive text. While the changes in this file are correct, I've identified related redundancies in the 1502_spec.json configuration file that could be cleaned up to improve maintainability. My review comments provide details on these suggested cleanups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants