Rewrite provenance/source/dataset documentation#690
Rewrite provenance/source/dataset documentation#690kmoscoe merged 68 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the accuracy and clarity of the Data Commons documentation, particularly for the fundamental concepts of provenance, source, and dataset. It addresses previous inaccuracies in the "Key concepts" section, updates associated diagrams for correct rendering, and expands the glossary to include formal definitions for these critical terms, ensuring a more consistent and understandable data model explanation for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a much-needed rewrite of the documentation for provenance, source, and dataset, improving correctness and clarity. It also fixes broken image links by removing unnecessary Liquid tags. The changes are a significant improvement. I've added a few comments to address minor typos and suggest a clarification for a potentially confusing sentence.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
beets
left a comment
There was a problem hiding this comment.
LGTM - thanks for the update!
The "Key concepts" section on provenances etc. was incorrect in several places, including the diagram. This PR rewrites that section and:
Staged at http://bullie.svl.corp.google.com:4000