Open
Conversation
arnaudfnr
approved these changes
Feb 26, 2026
webapp/src/widgets/map/Map.tsx
Outdated
| if (!mapApiRef.current) { | ||
| try { | ||
| mapApiRef.current = createMap(containerSelector, STYLE_URL); | ||
| // console.log("Create map.", mapSettings); |
webapp/package.json
Outdated
| "class-variance-authority": "^0.7.1", | ||
| "clsx": "^2.1.1", | ||
| "coordo": "github:dataforgoodfr/Coordonnees#main", | ||
| "coordo": "github:dataforgoodfr/Coordonnees#feat/init-map-options", |
Collaborator
There was a problem hiding this comment.
To update when the PR is merged on Coordo side
arnaudfnr
requested changes
Feb 26, 2026
webapp/src/widgets/map/Map.tsx
Outdated
| }); | ||
|
|
||
| // Update map settings | ||
| mapApiRef.current?.mapInstance.on("move", (event) => { |
Collaborator
There was a problem hiding this comment.
Ideally, we prefer never to use mapInstance. We made it accessible to not block the development process, but here I suggest we should think about a way to set this event listener through the API.
Collaborator
There was a problem hiding this comment.
Maybe we could add a method "addEventListener" to the API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : #59
J'ai pu tester la PR de coordo dataforgoodfr/Coordonnees#33 et tous fonctionne.