Conversation
Comment on lines
-2
to
+4
| import { createMap } from "coordo"; | ||
| import { type FC, useEffect, useRef, useState } from "react"; | ||
|
|
||
| import { API_URL } from "@shared/api/client"; | ||
| import { createMap } from "coordo"; |
Collaborator
There was a problem hiding this comment.
Maybe it's the format on save or the biome ordering that is different than previous configuration with prettier, but you moved createMap which has a ts-expect-error (missing types from coordo)
(which explains why the CI failed)
Collaborator
Author
There was a problem hiding this comment.
Oh ok, I didn't see the ts ignore at first.
Yes the formatter moved the import at top and broke the proximity of the ts silence.
david-bretaud-dev
approved these changes
Mar 1, 2026
Collaborator
david-bretaud-dev
left a comment
david-bretaud-dev
left a comment
There was a problem hiding this comment.
I think you can rebase, recently Arnaud merged a PR with a lot of missing changes in the lockfile, I think they are the same changes
jbuiquan
force-pushed
the
fix/map-partially-hidden
branch
3 times, most recently
from
a49b03f to
cd929dd
Compare
jbuiquan
force-pushed
the
fix/map-partially-hidden
branch
from
cd929dd to
74dde84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #58
min-h-svhcomme classe.Cela mettait une hauteur min de la taille de l'écran c'est donc pour ça qu'il manquait toujours un bout en bas. Etant donné que d'autres elements sont affichés (notamment le Header), la taille de la sidebar dépasse forcément si elle meme fait la taille de l'ecran !
Idem pour le
h-screendans le fichier Map.tsx.h-svhpour le RootLayout plutôt que h-screenDéfinition svh : https://tailwindcss.com/docs/height#matching-small-viewport (la taille minimum sans tenir compte des elements d'UI de l'appareil)
Le package-lock.json n'était pas à jour