Conversation
Pamplemousse
reviewed
Mar 3, 2026
There was a problem hiding this comment.
Very nice!
Here are a couple of things that could also be helpful:
- structure a subfolder to organise pieces of code related to article collection (aking to
ingestion/parsing), for exampleingestion/article_collection- with a
README.mdthat has a little bit of documentation (with how to install, use)
- with a
- specify the required dependencies in the root's
pyproject.toml
| return f"{uri}/document" | ||
|
|
||
|
|
||
| def set_output_file(doi: str, output_dir: str = "pdf") -> str: |
There was a problem hiding this comment.
The return type could be Path, as it is probably more adequate than str to represent a filesystem location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script allows to download a pdf from the article's DOI via the HAL API.
Needs to
pip install requests.