feat: implement Encoder for pgwire CopyEncoder#286
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements
Encoderfor upcomingCopyEncoderof pgwire, for data encoding in COPY OUT.It also adds a new interface to take_row from the encoder.
this is an example of using unified interface for both encoders in GreptimeDB: https://github.com/GreptimeTeam/greptimedb/pull/7709/changes#diff-1ae1a71dee12c94a37c1a50d6bfa54d539240569832b971a1916288b102a63f0R97
Will implement COPY TO STDOUT in datafusion-postgres too so an optimized adbc-postgres will work with this library.