feat(notifications): add accepted and refused membership request#928
Merged
nicolaskempf57 merged 8 commits intomainfrom Feb 23, 2026
Merged
feat(notifications): add accepted and refused membership request#928nicolaskempf57 merged 8 commits intomainfrom
nicolaskempf57 merged 8 commits intomainfrom
Conversation
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
as code owners
ThibaudDauce
requested changes
Feb 17, 2026
Contributor
ThibaudDauce
left a comment
ThibaudDauce
left a comment
There was a problem hiding this comment.
The two new components are really similar, could you create a single component with a type prop?
ThibaudDauce
approved these changes
Feb 18, 2026
Contributor
ThibaudDauce
left a comment
ThibaudDauce
left a comment
There was a problem hiding this comment.
You really don't want to merge the two components? :-D
nicolaskempf57
deleted the
feat_add_membership_response_notifications
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notifications