fix: Handle inhomogeneous array shapes in to_arrays()#1382
Merged
dimitri-yatsenko merged 2 commits intomaint/2.0from Feb 5, 2026
Merged
fix: Handle inhomogeneous array shapes in to_arrays()#1382dimitri-yatsenko merged 2 commits intomaint/2.0from
dimitri-yatsenko merged 2 commits intomaint/2.0from
Conversation
When arrays have different shapes, np.array(values, dtype=object) can still fail due to numpy's broadcasting behavior. Instead, create an empty object array and assign elements individually. This matches v0.14.7 behavior where blobs were extracted from structured arrays with object dtype columns. Fixes #1380 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Regression tests for #1380 - verify that arrays of different shapes are handled correctly without ValueError. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ttngu207
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_arrays()failing when arrays have different but "almost compatible" shapes (e.g.,(100,)vs(100, 1))Problem
When fetching blob attributes containing arrays of different shapes,
to_arrays()would fail:The fallback
np.array(values, dtype=object)still fails because numpy tries to broadcast shapes that are "almost compatible".Solution
Instead of
np.array(values, dtype=object), create an empty object array and assign elements individually:This matches v0.14.7 behavior where
fetch(*attrs)extracted columns from structured arrays withdtype=object, preserving individual array shapes.Test plan
Fixes #1380
🤖 Generated with Claude Code