Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Displays Chicago's community areas and shades them depending on how many new restaurant permits were issued in a given year. Adds some descriptive capabilities for each community on hover.
Notes
When I was working on the challenge I debated having multiple
useEffect()calls to handle state updates for the total permit numbers. Mainly because I was learning react and confused. I went with one since everything has the same dependency on the data endpoint.I haven't used React much, what are best practices around
useEffect()? Could we calculate everything during rendering in this case? Might look at that.reference react docs - https://react.dev/learn/you-might-not-need-an-effect