This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Rebase ardm changes on top of most recent DM master to make this releasable as 1.3#21
Open
martinemde wants to merge 11 commits intodatamapper:masterfrom
Open
Rebase ardm changes on top of most recent DM master to make this releasable as 1.3#21martinemde wants to merge 11 commits intodatamapper:masterfrom
martinemde wants to merge 11 commits intodatamapper:masterfrom
Conversation
Author
|
Nevermind, seems we're good anyway. Just a mistake on my end. |
This conversion is done by Transpec 3.0.7 with the following command:
transpec
* 64 conversions
from: obj.should
to: expect(obj).to
* 53 conversions
from: == expected
to: eq(expected)
* 16 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 4 conversions
from: <= expected
to: be <= expected
* 4 conversions
from: >= expected
to: be >= expected
* 1 conversion
from: pending { do_something_fail }
to: pending; do_something_fail
For more details: https://github.com/yujinakayama/transpec#supported-conversions
martinemde
force-pushed
the
dm-master-rebase
branch
from
d40b836 to
9eeea8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's all my changes to modernize this one. Please check these thoroughly for ardm mentions. I tried to remove them all.