This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Work with ruby 2.3's --enable-frozen-string-literal#90
Open
jeremyevans wants to merge 1 commit intodatamapper:masterfrom
Open
Work with ruby 2.3's --enable-frozen-string-literal#90jeremyevans wants to merge 1 commit intodatamapper:masterfrom
jeremyevans wants to merge 1 commit intodatamapper:masterfrom
Conversation
These changes are the minimal ones necessary to allow Sequel's specs to pass. There may well be other changes that are required.
Contributor
|
Curious, how have you been testing this? I tried with |
Contributor
Author
|
If you just want to worry about frozen string issues in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are the minimal ones necessary to allow Sequel's specs
to pass. There may well be other changes that are required.