Install-DbaMaintenanceSolution: change Compress/Verify/CheckSum to ValidateSet string params#10247
Open
andreasjordan wants to merge 1 commit intodevelopmentfrom
Open
Install-DbaMaintenanceSolution: change Compress/Verify/CheckSum to ValidateSet string params#10247andreasjordan wants to merge 1 commit intodevelopmentfrom
andreasjordan wants to merge 1 commit intodevelopmentfrom
Conversation
…lidateSet string params Fixes #10183. The -Compress, -Verify and -CheckSum parameters were switches, which caused documentation/behaviour mismatches: - Switch default ($false) would set @compress = 'N' even when not specified - Switch default ($false) would override Ola's @verify = 'Y' default Changed all three to [string] with [ValidateSet('Default', 'ForceOn', 'ForceOff', 'Remove')]: - Default: leaves job text unchanged (Ola's defaults: Verify='Y', Checksum='Y', no Compress) - ForceOn: explicitly sets parameter to 'Y' - ForceOff: explicitly sets parameter to 'N' - Remove: strips the parameter from job text entirely Updated NUL+Verify validation to check for ForceOff/Remove instead of boolean false. Updated all integration tests to use the new string values. (do *MaintenanceSolution*) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
Contributor
|
Looks mostly good. My objections are fairly minor. My only major objection is the lack of test coverage. Specifically, only I would also like to import whatever we can from #10184, but converting that to use the new strings will be tedious. |
Collaborator
Author
|
Ok, I will try and see if Claude can help here tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10183.
Changed
-Compress,-Verify, and-CheckSumfrom[switch]to[string]parameters with[ValidateSet('Default', 'ForceOn', 'ForceOff', 'Remove')].Default= leave Ola's job text unchanged (Verify='Y', Checksum='Y', no Compress)ForceOn= explicitly set parameter to 'Y'ForceOff= explicitly set parameter to 'N'Remove= strip the parameter from job text entirelyGenerated with Claude Code