feat: Add ResourceIndexPolicy for Domain, DNSZone, Contact, and Note#215
Merged
kevwilliams merged 3 commits intomainfrom Apr 13, 2026
Merged
feat: Add ResourceIndexPolicy for Domain, DNSZone, Contact, and Note#215kevwilliams merged 3 commits intomainfrom
kevwilliams merged 3 commits intomainfrom
Conversation
Deploys search index policies for four additional resource types so they appear in search.miloapis.com results alongside existing User resources. - Domain (networking.datumapis.com/v1alpha): indexes domainName, apex, nameservers, and registrar/registry names - DNSZone (dns.networking.miloapis.com/v1alpha1): indexes domainName and dnsZoneClassName - Contact (notification.miloapis.com/v1alpha1): indexes givenName, familyName, and email address - Note (notes.miloapis.com/v1alpha1): indexes content and nextAction Contact uses spec.givenName/spec.familyName per the actual milo type (not firstName/lastName as referenced in the issue).
Contributor
Author
|
I wasn't 100% sure on all the fields but took a swing at it. Let me know what you think @scotwells |
scotwells
reviewed
Apr 13, 2026
- Remove conditions blocks (resources always have a name) - Add display-name and description annotation fields to all policies - Drop spec.dnsZoneClassName from DNSZone policy (all zones use same class) - Remove Note ResourceIndexPolicy entirely
scotwells
reviewed
Apr 13, 2026
Remove status fields (nameservers, registrar, registry, apex) from Domain policy and drop metadata.namespace from all policies — users search by name, display name, description, and resource-specific identifiers like domainName or email, not system-populated metadata.
scotwells
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResourceIndexPolicyresources for four additional types so they appear insearch.miloapis.comresults alongside the existing User policysearch.miloapis.comkustomization componentDetails
networking.datumapis.comv1alphadomainName,status.apex,status.nameservers[0].hostname, registrar/registry namesdns.networking.miloapis.comv1alpha1domainName,dnsZoneClassNamenotification.miloapis.comv1alpha1givenName,familyName, email addressnotes.miloapis.comv1alpha1content,nextActionNote: Contact uses
spec.givenName/spec.familyName— the issue sample referencedfirstName/lastNamewhich does not match the actual milo type definition.Note: Domain version is
v1alpha(no trailing1) — this is intentional. Thenetwork-services-operatorhas two separate API packages:api/v1alpha(Domain) andapi/v1alpha1(Connector, ConnectorAdvertisement, ConnectorClass).Closes #214
Test plan