Skip to content

[rofi-sensible-terminal] Use /bin/sh instead of /usr/bin/env bash#1478

Open
jirutka wants to merge 1 commit intodavatorium:nextfrom
jirutka:rofi-convert-theme-sh
Open

[rofi-sensible-terminal] Use /bin/sh instead of /usr/bin/env bash#1478
jirutka wants to merge 1 commit intodavatorium:nextfrom
jirutka:rofi-convert-theme-sh

Conversation

@jirutka
Copy link
Copy Markdown
Contributor

@jirutka jirutka commented Sep 26, 2021

This script is fully POSIX-sh compatible, i.e. it's portable and can be run in any shell, not just bash. It's incorrect to assume that bash is available on every *nix system (it's not), but /bin/sh is.

This script is fully POSIX-sh compatible, i.e. it's portable and can be
run in any shell, not just bash. It's incorrect to assume that bash is
available on every *nix system (it's not), but /bin/sh is.
@metov
Copy link
Copy Markdown

metov commented Oct 4, 2021

The change to sh seems like a good idea, but isn't it better to make it /usr/bin/env sh?

@jirutka
Copy link
Copy Markdown
Contributor Author

jirutka commented Oct 4, 2021

isn't it better to make it /usr/bin/env sh?

No, /bin/sh is de-facto standard supported by all *nix systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants