Skip to content

Please consider the following formatting changes to #14921 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 2 commits into from
Closed

Please consider the following formatting changes to #14921 #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40842b6
TPC Splines: keep old cropping scheme
cbmsw Feb 5, 2026
70f6475
Please consider the following formatting changes
alibuild Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ void TPCFastSpaceChargeCorrection::setActualBufferAddress(char* actualFlatBuffer
}

newSectorRow.resetMaxValues();
newSectorRow.updateMaxValues(-50.f, -50.f, -50.f);
newSectorRow.updateMaxValues(50.f, 50.f, 50.f);
newSectorRow.updateMaxValues(-100.f, -100.f, -100.f);
newSectorRow.updateMaxValues(100.f, 100.f, 100.f);
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions GPU/TPCFastTransformation/TPCFastSpaceChargeCorrection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,9 +491,14 @@ GPUdi() std::array<float, 3> TPCFastSpaceChargeCorrection::getCorrectionLocal(in
float dxyz[3];
spline.interpolateAtU(splineData, val[0], val[1], dxyz);

if (CAMath::Abs(dxyz[0]) > 100.f || CAMath::Abs(dxyz[1]) > 100.f || CAMath::Abs(dxyz[2]) > 100.f) {
val[2] = 0.f; // TODO: DR: Protect from FPEs, fix upstream and remove once guaranteed that it is fixed
}

float dx = val[2] * GPUCommonMath::Clamp(dxyz[0], info.minCorr[0], info.maxCorr[0]);
float dy = val[2] * GPUCommonMath::Clamp(dxyz[1], info.minCorr[1], info.maxCorr[1]);
float dz = val[2] * GPUCommonMath::Clamp(dxyz[2], info.minCorr[2], info.maxCorr[2]);

return {dx, dy, dz};
}

Expand All @@ -503,6 +508,9 @@ GPUdi() float TPCFastSpaceChargeCorrection::getCorrectionXatRealYZ(int32_t secto
auto val = convRealLocalToGrid(sector, row, realY, realZ);
float dx = 0;
getSplineInvX(sector, row).interpolateAtU(getCorrectionDataInvX(sector, row), val[0], val[1], &dx);
if (CAMath::Abs(dx) > 100.f) {
val[2] = 0.f; // TODO: DR: Protect from FPEs, fix upstream and remove once guaranteed that it is fixed
}
dx = val[2] * GPUCommonMath::Clamp(dx, info.minCorr[0], info.maxCorr[0]);
return dx;
}
Expand All @@ -513,6 +521,9 @@ GPUdi() std::array<float, 2> TPCFastSpaceChargeCorrection::getCorrectionYZatReal
const auto& info = getSectorRowInfo(sector, row);
float dyz[2];
getSplineInvYZ(sector, row).interpolateAtU(getCorrectionDataInvYZ(sector, row), val[0], val[1], dyz);
if (CAMath::Abs(dyz[0]) > 100.f || CAMath::Abs(dyz[1]) > 100.f) {
val[2] = 0.f; // TODO: DR: Protect from FPEs, fix upstream and remove once guaranteed that it is fixed
}
dyz[0] = val[2] * GPUCommonMath::Clamp(dyz[0], info.minCorr[1], info.maxCorr[1]);
dyz[1] = val[2] * GPUCommonMath::Clamp(dyz[1], info.minCorr[2], info.maxCorr[2]);
return {dyz[0], dyz[1]};
Expand Down