Make null string config test more robust#1824
Merged
rolandwalker merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
This test is occasionally failing in CI since we started running tests in random order. The failure message says that the database cannot be found. However the test does not need a database to be selected in order to run. This may be true of other tests, so we generalize CLI_ARGS_WITHOUT_DB, as it may be used elsewhere if similar failures are observed.
rolandwalker
force-pushed
the
RW/more-robust-null-string-config-test
branch
from
a4b5add to
0abdb72
Compare
scottnemes
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This test is occasionally failing in CI since we started running tests in random order. The failure message says that the database cannot be found. However the test does not need a database to be selected in order to run.
This may be true of other tests, so we generalize
CLI_ARGS_WITHOUT_DB, as it may be used elsewhere if similar failures are observed.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).