Open
Conversation
Contributor
Author
|
@rolandwalker This is a pretty big one, so feel free to suggest any changes you might want for the general flow or messaging or whatever. Tried to keep it as minimal as possible to get the functionality, but it touches a lot of areas since a normal login has a lot going on behind the scenes as you know. |
…me a user with an expired password attempts to connect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for mycli to go into "sandbox mode" when a user with an expired passwords is used to connect. Prior to this change, when a user with an expired password connects it will simply tell them the password is expired. With this change, the user goes into a restricted "sandbox" mode, which only allows the user to change their password, or quit. Once the password is changed, the client will then automatically reconnect using the updated password and go into the normal "full" mode and allow normal operation.
The behavior may be controlled by either the
connect_expired_passwordconfig option (True by default), or the--connect-expired-passwordflag.Expire user's password:
Existing behavior when logging in with the expired password user:
New behavior when logging in with the expired password user:
Trying to run a command:
Change password:
Note it then reconnects using the updated password and you are free to continue on as normal.
Resolves #440
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).