Conversation
sergeyteleshev
force-pushed
the
8433-cb-replace-material-ui-with-native-css-variables-and-tailwind-utilities
branch
from
45a3d76 to
53ef45a
Compare
…-variables-and-tailwind-utilities
SychevAndrey
previously requested changes
Mar 4, 2026
Contributor
SychevAndrey
left a comment
SychevAndrey
left a comment
There was a problem hiding this comment.
This is a big step forward to clean CSS in the project! Good job. 👍🏻
Please check noted places and let's try to use css nesting more and don't forget about layers.
| */ | ||
|
|
||
| .cm-tooltip.cm-tooltip-autocomplete { | ||
| & > :global(ul) { |
Contributor
There was a problem hiding this comment.
you use :global here, but this css file is not .module.css
plus for plain css we should use @layer
Wroud
reviewed
Mar 5, 2026
Comment on lines
+35
to
+41
| background: var(--theme-sub-secondary) !important; | ||
| color: var(--theme-on-secondary) !important; | ||
| } | ||
|
|
||
| & li[aria-selected='true'] { | ||
| background: var(--theme-secondary) !important; | ||
| color: var(--theme-text-primary-on-light) !important; |
Member
There was a problem hiding this comment.
it wasn't !important in scss varian, why it changed?
…-variables-and-tailwind-utilities
This reverts commit 78229ac.
devnaumov
previously approved these changes
Mar 30, 2026
Wroud
previously approved these changes
Mar 30, 2026
Comment on lines
+11
to
+12
| // Keep it so build can pass | ||
| export default ModuleRegistry.add({ |
Member
There was a problem hiding this comment.
please remove.
you also might need to remove "./module": "./lib/module.js", in the package.json
this file not required for the build
…-variables-and-tailwind-utilities
…-variables-and-tailwind-utilities
devnaumov
requested changes
Mar 31, 2026
| * Licensed under the Apache License, Version 2.0. | ||
| * you may not use this file except in compliance with the License. | ||
| */ | ||
| @layer components { |
Member
There was a problem hiding this comment.
we use @layer components across all components such as button, combobox, radio, please explain why do we need to remove it, because we cant delete logic like this, we should do it consistently across all files or fix it in different way
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
devnaumov
previously approved these changes
Mar 31, 2026
…-variables-and-tailwind-utilities
…-variables-and-tailwind-utilities
…-variables-and-tailwind-utilities
…-variables-and-tailwind-utilities
…-variables-and-tailwind-utilities
* Reduce hover opacity in ripple effect * Update ripple.css
devnaumov
approved these changes
Apr 2, 2026
devnaumov
deleted the
8433-cb-replace-material-ui-with-native-css-variables-and-tailwind-utilities
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/8433