dbeaver/pro#8553 sql execution plan diagram#4218
Open
SychevAndrey wants to merge 56 commits intodevelfrom
Open
dbeaver/pro#8553 sql execution plan diagram#4218SychevAndrey wants to merge 56 commits intodevelfrom
SychevAndrey wants to merge 56 commits intodevelfrom
Conversation
…lectedNodeId prop
separate state, add l10n, make toolbar composable
… plan diagram component
…ional navigation
…in ILayoutEdge interface
…Tree and buildTree functions
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...pp/common-react/@dbeaver/react-execution-plan-diagram/src/api/createExecutionPlanDiagram.tsx
Fixed
Show fixed
Hide fixed
…pdate references
…g args interpolation
devnaumov
requested changes
Mar 18, 2026
| } | ||
|
|
||
| /** Invisible child component that captures toolbar actions from DiagramContext. */ | ||
| function ActionsCapture({ onActions }: { onActions: (actions: IDiagramActions | null) => void }) { |
Member
There was a problem hiding this comment.
All logic related to the execution plan diagrams should be inside EE repos
Member
There was a problem hiding this comment.
i think this is not critical, because it can't be used as-is, and without diagram data itself it's not so usefull
Wroud
requested changes
Mar 18, 2026
...pp/common-react/@dbeaver/react-execution-plan-diagram/src/api/createExecutionPlanDiagram.tsx
Outdated
Show resolved
Hide resolved
...pp/common-react/@dbeaver/react-execution-plan-diagram/src/api/createExecutionPlanDiagram.tsx
Outdated
Show resolved
Hide resolved
...pp/common-react/@dbeaver/react-execution-plan-diagram/src/api/createExecutionPlanDiagram.tsx
Outdated
Show resolved
Hide resolved
...eact/@dbeaver/react-execution-plan-diagram/src/components/ExecutionPlanCollapseIndicator.tsx
Outdated
Show resolved
Hide resolved
...p/common-react/@dbeaver/react-execution-plan-diagram/src/components/ExecutionPlanDiagram.tsx
Outdated
Show resolved
Hide resolved
webapp/common-react/@dbeaver/react-execution-plan-diagram/src/components/ExecutionPlanNode.tsx
Outdated
Show resolved
Hide resolved
...ommon-react/@dbeaver/react-execution-plan-diagram/src/components/ExecutionPlanNodeMetric.tsx
Outdated
Show resolved
Hide resolved
.../common-react/@dbeaver/react-execution-plan-diagram/src/components/ExecutionPlanViewport.tsx
Outdated
Show resolved
Hide resolved
webapp/common-react/@dbeaver/react-execution-plan-diagram/src/hooks/usePlanLayout.ts
Outdated
Show resolved
Hide resolved
webapp/common-react/@dbeaver/react-execution-plan-diagram/src/hooks/usePanZoom.ts
Outdated
Show resolved
Hide resolved
…ecutionPlanViewport
…nent and clean up CSS
…eEffectEvent for stable callback
Wroud
requested changes
Mar 19, 2026
Comment on lines
47
to
48
| function ActionsCapture({ actionsRef }: { actionsRef: { current: IDiagramActions | null } }) { | ||
| const actions = useContext(DiagramContext); |
Member
There was a problem hiding this comment.
you don't need this component at all, please remove it
Comment on lines
+124
to
+134
| data={state.data} | ||
| options={state.options} | ||
| selectedNodeId={state.selectedNodeId} | ||
| onNodeSelect={(nodeId, node) => { | ||
| state.selectedNodeId = nodeId; | ||
| state.callbacks.onNodeSelect?.(nodeId, node); | ||
|
|
||
| window.onPlanNodeSelected?.(nodeId); | ||
|
|
||
| render(); | ||
| }} |
Member
There was a problem hiding this comment.
pass a callback to the ref property to get actions
Member
There was a problem hiding this comment.
let diagramActions: IDiagramActions | null = null;
...
<ExecutionPlanDiagram
ref={actions => {
diagramActions = actions;
}}
...
zoomOut(): void {
diagramActions?.zoomOut();
},
…eExecutionPlanDiagram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
component + small APP for Java integration