dbeaver/pro#7806 remove MenuBarSmallItem#4224
Conversation
devnaumov
requested review from
SychevAndrey,
Wroud and
sergeyteleshev
and removed request for
Wroud
| */ | ||
| @layer components { | ||
| .dbv-kit-button { | ||
| --dbv-kit-btn-padding-inline: 15px; |
There was a problem hiding this comment.
what happened to this style?
There was a problem hiding this comment.
Padding applies along with size prop, previously size prop did not work in terms of padding, for example buttons with small size. Every size applies its own padding, seems like we dont need this one
| export const Button = componentProviderWrapper('Button', ButtonBase); | ||
| export const ButtonIcon = componentProviderWrapper('ButtonIcon', ButtonBaseIcon); | ||
|
|
||
| export const UnstyledButton = AriaButton; |
There was a problem hiding this comment.
I'm not a fan of this alias. What was the purpose of creating it? Just to hide Aria naming?
There was a problem hiding this comment.
We dont expose lib naming to the core repo. UnstyledButton is common name for buttons that are headless
https://mantine.dev/core/unstyled-button/
| */ | ||
| @layer components { | ||
| .dbv-kit-button { | ||
| --dbv-kit-btn-padding-inline: 15px; |
There was a problem hiding this comment.
The padding depends on the button size, otherwise it overrides
| export const Button = componentProviderWrapper('Button', ButtonBase); | ||
| export const ButtonIcon = componentProviderWrapper('ButtonIcon', ButtonBaseIcon); | ||
|
|
||
| export const UnstyledButton = AriaButton; |
There was a problem hiding this comment.
We dont expose lib naming to the core repo. UnstyledButton is common name for buttons that are headless
https://mantine.dev/core/unstyled-button/
6 participants
closes 7806