Support [day of week] [nth] [month name] [year] format#15
Support [day of week] [nth] [month name] [year] format#15dbernheisel merged 2 commits intodbernheisel:mainfrom
Conversation
This adds support for dates formatted like: - Sunday 5th Jan 2025 - Tuesday 2nd Feburary 2024 - 1st January 2025
s3cur3
force-pushed
the
weekday-day-month-year
branch
from
ff57067 to
f5ed29e
Compare
|
Oh no, the tests are failing! I swear they passed locally... I'll look into it... |
|
Oh! I think the tests are failing because I didn't commit the modified |
|
@s3cur3 correct, I can get to it or you can, but otherwise LGTM. |
|
Ah, very good! I've added it. (Would you like me to also edit the contributing guide to remove the instruction not to commit the compiled NimbleParsec artifacts?) |
|
@s3cur3 I remember why I did it this way -- I wanted to review the exs file and not the ex (it gets so large). I don't want contributors to trip over this next time, so I'll adjust the CI process to generate the ex file before running tests, and the publishing process will ensure it's generated and up to date. I'll take care of this tonight! Thanks for the contribution ❤️ |
|
Ah, understood. Thank you! |
2 participants
Hi David! 👋 Thanks for this! I'm using it when parsing dates in WHOIS records for the Whois package.
This PR adds support for dates formatted like: