Open
Conversation
marcodamore
force-pushed
the
marco_add_partner_source
branch
from
0aa9fd4 to
8a0947f
Compare
marcodamore
force-pushed
the
marco_add_partner_source
branch
from
0aa2205 to
5fab504
Compare
marcodamore
force-pushed
the
marco_add_partner_source
branch
from
1269bcd to
dcb2f7b
Compare
serramatutu
reviewed
Apr 3, 2025
| auth_token: str, | ||
| url_format: Optional[str] = None, | ||
| timeout: Optional[Union[TimeoutOptions, float, int]] = None, | ||
| client_partner_source: Optional[str] = None, |
Collaborator
There was a problem hiding this comment.
I'd prefer if we moved this to a property and out of the constructor to reduce the cognitive overload of regular users, since 99% of people won't need to set this param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add ability to specify partner source in public SL SDK. Default to
sl-python-sdk, but also start passingdbt-e2e-testsfor queries executed by our test suite. Tested and confirmed the test suite partner source is flowing through our monitoring system ✨