V3 Work

[dcarbone]

Goals:

• Remove useless comments.
• Remove FakeMap class.
• Remove FakeSlice class.
• Remove ScalarType interface.
• Use parameterized constructors for all models.
• Remove Transcoding type and usage.
• Remove Unmarshaller and Marshaller traits and flow.
• Localize entirety of json encoding / decoding to each individual model class.
• Better support for dynamically declared fields.
• Enable all Time\Duration values to accept null|int|float|string|\DateInterval|Time\Duration for construction.
• Create enum types for enum values.

[Copilot]

Copilot reviewed 32 out of 51 changed files in this pull request and generated 2 comments.

Files not reviewed (19)

• src/ACL/ACLAuthMethod.php: Language not supported
• src/ACL/ACLAuthMethodListEntry.php: Language not supported
• src/ACL/ACLAuthMethodListEntryQueryResponse.php: Language not supported
• src/ACL/ACLAuthMethodNamespaceRule.php: Language not supported
• src/ACL/ACLAuthMethodQueryResponse.php: Language not supported
• src/ACL/ACLAuthMethodWriteResponse.php: Language not supported
• src/ACL/ACLBindingRule.php: Language not supported
• src/ACL/ACLBindingRuleQueryResponse.php: Language not supported
• src/ACL/ACLBindingRuleWriteResponse.php: Language not supported
• src/ACL/ACLBindingRulesQueryResponse.php: Language not supported
• src/ACL/ACLClient.php: Language not supported
• src/ACL/ACLEntriesResponse.php: Language not supported
• src/ACL/ACLEntry.php: Language not supported
• src/ACL/ACLLink.php: Language not supported
• src/ACL/ACLLoginParams.php: Language not supported
• src/ACL/ACLNodeIdentity.php: Language not supported
• src/ACL/ACLOIDCAuthURLParams.php: Language not supported
• src/ACL/ACLOIDCCallbackParams.php: Language not supported
• src/ACL/ACLPolicy.php: Language not supported

Comments suppressed due to low confidence (1)

README.md:106

• There appears to be an extra closing bracket in the client instantiation, which may lead to a syntax error in the example code. Consider removing the extra bracket.

$proxyClient = new \GuzzleHttp\Client(['proxy' => 'whatever proxy you want']]);

[Copilot]

Copilot reviewed 41 out of 60 changed files in this pull request and generated 1 comment.

Files not reviewed (19)

• src/ACL/ACLAuthMethod.php: Language not supported
• src/ACL/ACLAuthMethodListEntry.php: Language not supported
• src/ACL/ACLAuthMethodListEntryQueryResponse.php: Language not supported
• src/ACL/ACLAuthMethodNamespaceRule.php: Language not supported
• src/ACL/ACLAuthMethodQueryResponse.php: Language not supported
• src/ACL/ACLAuthMethodWriteResponse.php: Language not supported
• src/ACL/ACLBindingRule.php: Language not supported
• src/ACL/ACLBindingRuleQueryResponse.php: Language not supported
• src/ACL/ACLBindingRuleWriteResponse.php: Language not supported
• src/ACL/ACLBindingRulesQueryResponse.php: Language not supported
• src/ACL/ACLClient.php: Language not supported
• src/ACL/ACLEntriesResponse.php: Language not supported
• src/ACL/ACLEntry.php: Language not supported
• src/ACL/ACLLink.php: Language not supported
• src/ACL/ACLLoginParams.php: Language not supported
• src/ACL/ACLNodeIdentity.php: Language not supported
• src/ACL/ACLOIDCAuthURLParams.php: Language not supported
• src/ACL/ACLOIDCCallbackParams.php: Language not supported
• src/ACL/ACLPolicy.php: Language not supported

Comments suppressed due to low confidence (1)

README.md:106

• An extra closing bracket appears in the instantiation of \GuzzleHttp\Client, which may result in a syntax error. Please remove the additional bracket.

$proxyClient = new \GuzzleHttp\Client(['proxy' => 'whatever proxy you want']]);