Skip to content

Flatten key lookup pointer loops #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dduan merged 1 commit into from
Feb 6, 2026
Merged

Flatten key lookup pointer loops #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 24 additions & 39 deletions Sources/TOMLDecoder/Parsing/Parser.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1905,21 +1905,16 @@ extension Parser {
guard let keyValueBase = keyValueBuffer.baseAddress else {
return nil
}
return indices.withUnsafeBufferPointer { indexBuffer in
guard let indexBase = indexBuffer.baseAddress else {
return nil
var i = 0
while i < indices.count {
let keyValueIndex = indices[i]
let keyValuePair = keyValueBase.advanced(by: keyValueIndex).pointee
if keyValuePair.keyHash == keyHash, keyValuePair.key == key {
return keyValueIndex
}
var i = 0
while i < indexBuffer.count {
let keyValueIndex = indexBase[i]
let keyValuePair = keyValueBase[keyValueIndex]
if keyValuePair.keyHash == keyHash, keyValuePair.key == key {
return keyValueIndex
}
i += 1
}
return nil
i += 1
}
return nil
}
}

Expand All @@ -1932,21 +1927,16 @@ extension Parser {
guard let keyArrayBase = keyArrayBuffer.baseAddress else {
return nil
}
return indices.withUnsafeBufferPointer { indexBuffer in
guard let indexBase = indexBuffer.baseAddress else {
return nil
}
var i = 0
while i < indexBuffer.count {
let keyArrayIndex = indexBase[i]
let keyArrayPair = keyArrayBase[keyArrayIndex]
if keyArrayPair.keyHash == keyHash, keyArrayPair.key == key {
return keyArrayIndex
}
i += 1
var i = 0
while i < indices.count {
let keyArrayIndex = indices[i]
let keyArrayPair = keyArrayBase.advanced(by: keyArrayIndex).pointee
if keyArrayPair.keyHash == keyHash, keyArrayPair.key == key {
return keyArrayIndex
}
return nil
i += 1
}
return nil
}
}

Expand All @@ -1959,21 +1949,16 @@ extension Parser {
guard let keyTableBase = keyTableBuffer.baseAddress else {
return nil
}
return indices.withUnsafeBufferPointer { indexBuffer in
guard let indexBase = indexBuffer.baseAddress else {
return nil
}
var i = 0
while i < indexBuffer.count {
let keyTableIndex = indexBase[i]
let keyTablePair = keyTableBase[keyTableIndex]
if keyTablePair.keyHash == keyHash, keyTablePair.key == key {
return keyTableIndex
}
i += 1
var i = 0
while i < indices.count {
let keyTableIndex = indices[i]
let keyTablePair = keyTableBase.advanced(by: keyTableIndex).pointee
if keyTablePair.keyHash == keyHash, keyTablePair.key == key {
return keyTableIndex
}
return nil
i += 1
}
return nil
}
}

Expand Down
Loading