DBZ-2619 Adding few social share buttons

[uidoyen]

No description provided.

[gunnarmorling]

So I like the idea of share buttons, but can we make them more privacy-friendly? I.e. instead of directly calling those remote URLs, put this behind one more click, so the user consciously opts into this. E.g. see here for one possible solution: https://www.heise.de/extras/socialshareprivacy/ (it's in German, but you'll find similar things described in English, too).

[uidoyen]

@gunnarmorling Updated the PR.

[gunnarmorling]

Hey @uidoyen, nice work overall! A few remarks:

• Let's remove Tumblr and Stumble, I don't think they're used that widely any more
• The letter icon seems oddly stretched, can you double check on this?
• I reckon FaceBook is a plain link and thus can be shown "enabled" right away?

[gunnarmorling]

Why do we need this cookie logic?

[uidoyen]

Cookie logic is to enable share buttons permanently.

[gunnarmorling]

Can we do without that permanent feature? We'd need cookie policy disclaimer and option to opt-out for European countries, and it's all not worth the hassle.

…

[uidoyen]

Can we do without that permanent feature? We'd need cookie policy disclaimer and option to opt-out for European countries, and it's all not worth the hassle.
…

Removed permanent feature.

[uidoyen]

Hey @uidoyen, nice work overall! A few remarks:

• Let's remove Tumblr and Stumble, I don't think they're used that widely any more
• The letter icon seems oddly stretched, can you double check on this?
• I reckon FaceBook is a plain link and thus can be shown "enabled" right away?

As per panzi/SocialSharePrivacy#50 Facebook is only a link and no request to Facebook is made to display it. Fixed the rest.

[gunnarmorling]

Hey @uidoyen, could you rebase this and push it to the preview environment if you got some cycles? @hguerrero was just asking for this feature :)

[uidoyen]

@gunnarmorling Done!

[gunnarmorling]

Thx! Did you push it to staging, I can't seem to find it there.

…

[uidoyen]

Thx! Did you push it to staging, I can't seem to find it there.
…

@gunnarmorling Just pushed it to staging

[uidoyen]

@gunnarmorling @hguerrero Could you please review the staging?

[Naros]

Hi @uidoyen I'm sorry this has fallen through the cracks. If this is still relevant, could you rebase this PR for me? I'll then take a look and review the changes, thanks!

[Naros]

❌ Developer Certificate of Origin (DCO) check failed.

Hi @uidoyen, please sign off all commits with:

git commit -s

If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes.