fix: pass userId to Segment identify and handle wallet account changes#295
Open
fix: pass userId to Segment identify and handle wallet account changes#295
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const [isLoading, setIsLoading] = useState(true) | ||
|
|
||
| const refreshConnectionData = useCallback(async () => { | ||
| const data = await getCurrentConnectionData() |
Collaborator
There was a problem hiding this comment.
I think we need a context and a provider for the wallet connection. If not, this hook will be called on each page load, trying to perform a connection with the connector and getting the credentials each time it can.
Collaborator
There was a problem hiding this comment.
We might want to extract the module from https://github.com/decentraland/internal-tools/tree/main/src/modules/wallet and use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analytics.identify()calls that passed ethAddress only as a traitinstead of as the userId (first argument), causing Segment to reuse the
cached userId when switching wallets
identifyUserutility in RequestPage instead of callinggetAnalytics()?.identify()directlyaccountsChangedlistener touseCurrentConnectionDataso pagesreact when the user switches wallet in their provider (e.g. MetaMask)
hooks.tsfile and consolidate imports tohook.ts