feat: add email-only sign-in option with dynamic wallet ordering by braianj · Pull Request #308 · decentraland/auth

braianj · 2026-03-03T19:58:09Z

This PR implements support for the email-only sign-in feature with dynamic wallet button ordering based on MetaMask
availability and user preferences.

New Features

Email-only sign-in mode (isOnlyEmailOption flag):

One-wallet mode (isSignInWithTwoOptions: false): Shows only MetaMask if available
Two-wallet mode (isSignInWithTwoOptions: true): Shows Google + MetaMask if available

Dynamic wallet ordering:

New useWalletOptions hook centralizes wallet ordering logic
Prioritizes Google and MetaMask based on feature flags
Gracefully handles missing wallet providers
Created useWalletOptions hook to encapsulate wallet ordering logic

Behavior

Default (flag disabled):
Wallet options match current/legacy behavior

Email-only mode with one wallet (isOnlyEmailOption: true, isSignInWithTwoOptions: false):

With MetaMask: Only MetaMask shown
Without MetaMask: No primary buttons, all in "More options" (Google first, MetaMask second)

Email-only mode with two wallets (isOnlyEmailOption: true, isSignInWithTwoOptions: true):

With MetaMask: Google first, MetaMask second
Without MetaMask: Only Google shown, MetaMask in "More options"

vercel · 2026-03-03T19:58:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
auth	Ready	Preview, Comment	Mar 6, 2026 9:28pm

…for mobile compatibility

LautaroPetaccio

Great work! 👍 I've left a couple of comments to review

LautaroPetaccio · 2026-03-04T21:36:19Z

-        ? connectionOptions?.extraOptions?.[0]
-        : connectionOptions?.secondary
-  const filteredExtraOptions = connectionOptions?.extraOptions?.filter(opt => opt !== ConnectionOptionType.EMAIL)
+  const { firstWalletOption, secondWalletOption, remainingWalletOptions } = useWalletOptions({


Be aware that the changes in ConnectionSecondaryButton and in Connection do impact the mobile site for Regenesis. Please check with them before merging.

LautaroPetaccio · 2026-03-04T21:37:50Z

+        const isMetamask = option === ConnectionOptionType.METAMASK
+        const shouldDisableMetamask = isMetamask && !isMetamaskAvailable


This function seems to be the same as the one used in the ConnectionPrimaryButton, what do you think about abstracting it?

LautaroPetaccio · 2026-03-04T21:39:33Z

+  const isOnlyEmailOption = flags[FeatureFlagsKeys.SIGN_IN_PRIMARY_OPTION]
+  const isSignInWithTwoOptions = variants[FeatureFlagsKeys.SIGN_IN_PRIMARY_OPTION]?.name === SignInPrimaryOption.TWO_OPTIONS


What if we have a signIgnOptions variable that has the values of one or two, for the options instead of two variables that get passed to the component?

I'mm make a refactor

LautaroPetaccio · 2026-03-04T21:46:48Z

+    )
+
+    // Current/Old behavior: show all options normally (when isOnlyEmailOption is disabled)
+    if (!isOnlyEmailOption) {


Is this correct? We're not using this logic in production, we're always showing the Metamask login as the primary action or am I missing something?

* fix: Incorrect handling of callback and magic re-log in * fix: Ignore error * Ignore MISSING_PKCE_METADATA error

…in the wallet (#321) * fix: prevent reporting to Sentry an error when the user rejects a tx in the wallet * fix: user rejected_action report to Sentry * refactor: PR feedback * chore: indent comment

…to extract params (#329) * fix: SSO log-in with Magic by waiting for redirect url before trying to extract params * fix: apply PR feedback --------- Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>

* feat: Asynchronously load OTP to reduce start time * fix: Linting * fix: Thirdweb fixed version

regenesis-claw

🚨 Breaking change for `/auth/mobile` route

The new useWalletOptions hook in Connection.tsx replaces the old inline wallet-filtering logic, but it drops the primary field entirely — it only considers secondary and extraOptions. This works for the desktop LoginPage (which always sets primary: EMAIL), but breaks all mobile configs where primary is a non-EMAIL option.

How it breaks

MobileProviderSelection renders <Connection> without passing signInOptionsMode, so the hook defaults to FULL mode:

// FULL mode in useWalletOptions:
firstWalletOption: connectionOptions?.secondary,
secondWalletOption: connectionOptions?.extraOptions?.[0],
remainingWalletOptions: connectionOptions?.extraOptions?.slice(1)

The primary field is completely ignored.

Affected mobile configs (`targetConfig.ts`):

Config	`primary`	Before	After
iOS	`APPLE`	APPLE shown as first button	❌ APPLE gone — shows WALLET_CONNECT instead
Android	`GOOGLE`	GOOGLE shown as first button	❌ GOOGLE dropped — shows WALLET_CONNECT instead
androidWeb3	`WALLET_CONNECT` (no secondary)	WALLET_CONNECT shown	❌ Nothing shown (secondary is undefined)
androidSocial	`EMAIL`	Works	✅ OK (primary is EMAIL)

Old logic (worked correctly for mobile):

const filteredPrimary =
  connectionOptions?.primary === ConnectionOptionType.EMAIL
    ? connectionOptions?.secondary
    : connectionOptions?.primary  // <-- kept non-EMAIL primary

The old code correctly fell through to use primary when it wasn't EMAIL. The new hook assumes primary is always EMAIL and discards it.

Suggested fix

The useWalletOptions hook needs to handle the case where primary is not EMAIL. In FULL mode (which is what mobile uses), if primary !== EMAIL, it should include primary in the wallet options — matching the old behavior. Alternatively, MobileProviderSelection could pass a dedicated mode or the mobile configs could be restructured.

Minor: `getSignInOptionsMode` doesn't check `variant.enabled`

If a variant exists but is disabled (enabled: false), getSignInOptionsMode would still return ONE instead of FULL:

if (!variant) {
  return SignInOptionsMode.FULL
}
// No check for variant.enabled here

Minor: Unused type addition

shouldShowGoogleOptionAsPrimary was added to ConnectionProps but doesn't appear to be used anywhere in this PR.

Requested by Gon via Slack

regenesis-claw · 2026-03-06T20:57:52Z

+    if (!signInOptionsMode || signInOptionsMode === SignInOptionsMode.FULL) {
+      return {
+        firstWalletOption: connectionOptions?.secondary,
+        secondWalletOption: connectionOptions?.extraOptions?.[0],


🚨 Bug — breaks mobile auth: In FULL mode, primary is completely ignored. The old code in Connection.tsx had:

const filteredPrimary = connectionOptions?.primary === ConnectionOptionType.EMAIL ? connectionOptions?.secondary : connectionOptions?.primary // kept non-EMAIL primary!

The mobile configs (ios, android, androidWeb3) set primary to APPLE, GOOGLE, or WALLET_CONNECT respectively. With this new code, those primary login options silently disappear from the UI.

This needs to include primary in the wallet options when primary !== EMAIL.

regenesis-claw · 2026-03-06T20:57:52Z

+function getSignInOptionsMode(variants: Partial<FeatureFlagsVariants>): SignInOptionsMode {
+  const variant = variants[FeatureFlagsKeys.SIGN_IN_PRIMARY_OPTION]
+
+  // If variant doesn't exist, use full mode (legacy behavior)


Minor: This doesn't check variant.enabled. If a variant exists but has enabled: false, it would still fall through to return ONE instead of FULL.

Suggestion:

if (!variant || !variant.enabled) { return SignInOptionsMode.FULL }

regenesis-claw · 2026-03-06T20:57:52Z

 type MetamaskEthereumWindow = typeof window.ethereum & { isMetaMask?: boolean }

 type ConnectionProps = {
+  shouldShowGoogleOptionAsPrimary?: boolean


Minor: shouldShowGoogleOptionAsPrimary is added here but doesn't appear to be used anywhere in this PR. Leftover?

…ons hook and fix 'more options' visibility

feat: add email-only sign-in option with dynamic wallet ordering

d3a77cf

fix: make email handlers optional and default feature flags to false …

51fedc5

…for mobile compatibility

vercel Bot deployed to Preview March 3, 2026 20:11 View deployment

braianj self-assigned this Mar 3, 2026

braianj added the enhancement New feature or request label Mar 3, 2026

Merge branch 'main' into feat/sign-in-primary-option

0ae9510

vercel Bot deployed to Preview March 4, 2026 17:38 View deployment

Merge branch 'main' into feat/sign-in-primary-option

5272403

vercel Bot deployed to Preview March 4, 2026 18:54 View deployment

LautaroPetaccio reviewed Mar 4, 2026

View reviewed changes

braianj added 2 commits March 5, 2026 13:22

refactor: usage of sign in option variants

056e0ab

test: update

cc7eb59

vercel Bot deployed to Preview March 5, 2026 16:39 View deployment

refactor: connetion buttons

9597192

vercel Bot deployed to Preview March 5, 2026 16:59 View deployment

refactor: sort imports

a38feda

vercel Bot deployed to Preview March 5, 2026 17:09 View deployment

braianj requested a review from LautaroPetaccio March 5, 2026 17:20

braianj added 2 commits March 5, 2026 18:50

Merge branch 'main' into feat/sign-in-primary-option

446833e

test: fix

bc281ea

vercel Bot deployed to Preview March 5, 2026 21:52 View deployment

Merge branch 'main' into feat/sign-in-primary-option

a081297

vercel Bot deployed to Preview March 5, 2026 22:04 View deployment

LautaroPetaccio approved these changes Mar 6, 2026

View reviewed changes

LautaroPetaccio and others added 5 commits March 6, 2026 17:17

fix: Incorrect handling of callback and magic re-log in (#325)

4521e31

* fix: Incorrect handling of callback and magic re-log in * fix: Ignore error * Ignore MISSING_PKCE_METADATA error

fix: Cannot read properties of null (reading length) (#327)

439f23f

fix: prevent reporting to Sentry an error when the user rejects a tx …

fa8cefb

…in the wallet (#321) * fix: prevent reporting to Sentry an error when the user rejects a tx in the wallet * fix: user rejected_action report to Sentry * refactor: PR feedback * chore: indent comment

feat: Add test-ids-to elements for E2E testing (#330)

881c184

LautaroPetaccio and others added 4 commits March 6, 2026 17:17

fix: Avatar particles image size (#332)

c8fb8e8

feat: Asynchronously load OTP to reduce start time (#331)

bb0f994

* feat: Asynchronously load OTP to reduce start time * fix: Linting * fix: Thirdweb fixed version

fix: Invalid method (#333)

56cf7f9

Merge branch 'main' into feat/sign-in-primary-option

1065e7d

vercel Bot deployed to Preview March 6, 2026 20:21 View deployment

Merge branch 'main' into feat/sign-in-primary-option

61567e9

vercel Bot deployed to Preview March 6, 2026 20:33 View deployment

chore: update package.lock.js

63b3890

vercel Bot deployed to Preview March 6, 2026 20:52 View deployment

regenesis-claw suggested changes Mar 6, 2026

View reviewed changes

fix: preserve non-EMAIL primary option (mobile flow) in useWalletOpti…

8de683d

…ons hook and fix 'more options' visibility

vercel Bot deployed to Preview March 6, 2026 21:20 View deployment

Merge branch 'main' into feat/sign-in-primary-option

e66caec

vercel Bot deployed to Preview March 6, 2026 21:28 View deployment

braianj requested a review from regenesis-claw March 6, 2026 21:30

braianj merged commit 0629665 into main Mar 6, 2026
9 checks passed

braianj deleted the feat/sign-in-primary-option branch March 6, 2026 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add email-only sign-in option with dynamic wallet ordering#308

feat: add email-only sign-in option with dynamic wallet ordering#308
braianj merged 24 commits intomainfrom
feat/sign-in-primary-option

braianj commented Mar 3, 2026

Uh oh!

vercel Bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

LautaroPetaccio left a comment

Uh oh!

LautaroPetaccio Mar 4, 2026

Uh oh!

LautaroPetaccio Mar 4, 2026

Uh oh!

LautaroPetaccio Mar 4, 2026

Uh oh!

braianj Mar 5, 2026

Uh oh!

LautaroPetaccio Mar 4, 2026

Uh oh!

Uh oh!

regenesis-claw left a comment

Uh oh!

regenesis-claw Mar 6, 2026

Uh oh!

regenesis-claw Mar 6, 2026

Uh oh!

regenesis-claw Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		const isMetamask = option === ConnectionOptionType.METAMASK
		const shouldDisableMetamask = isMetamask && !isMetamaskAvailable

		const isOnlyEmailOption = flags[FeatureFlagsKeys.SIGN_IN_PRIMARY_OPTION]
		const isSignInWithTwoOptions = variants[FeatureFlagsKeys.SIGN_IN_PRIMARY_OPTION]?.name === SignInPrimaryOption.TWO_OPTIONS

Conversation

braianj commented Mar 3, 2026

New Features

Behavior

Uh oh!

vercel Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LautaroPetaccio left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

regenesis-claw left a comment

Choose a reason for hiding this comment

🚨 Breaking change for /auth/mobile route

How it breaks

Affected mobile configs (targetConfig.ts):

Old logic (worked correctly for mobile):

Suggested fix

Minor: getSignInOptionsMode doesn't check variant.enabled

Minor: Unused type addition

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Mar 3, 2026 •

edited

Loading

🚨 Breaking change for `/auth/mobile` route

Affected mobile configs (`targetConfig.ts`):

Minor: `getSignInOptionsMode` doesn't check `variant.enabled`